Conversation
jbcoe
force-pushed
the
tutorials
branch
2 times, most recently
from
July 22, 2026 19:53
4d2bd17 to
321b94c
Compare
jbcoe
marked this pull request as ready for review
July 22, 2026 22:18
Collaborator
|
I think these are great, first 2 down and working through the 3rd now, but these are definitely useful (I'm learning reflection from the 3rd). Perhaps the files could be renamed with a number indicating the order of the tutorials?
The pedant in me finds it odd to start in the middle, go down and then go up in the file view in VSCode. |
Twon
reviewed
Jul 23, 2026
Twon
reviewed
Jul 23, 2026
RyanJK5
reviewed
Jul 23, 2026
RyanJK5
reviewed
Jul 25, 2026
RyanJK5
left a comment
RyanJK5
left a comment
Collaborator
There was a problem hiding this comment.
I just gave the tutorials an in-depth look, and I think they are very good! All of the information is accurate. I left some comments, mostly regarding additional pieces of the reflection tutorial worth acknowledging. Thanks for putting these together!
Owner
Author
|
@RyanJK5 thanks for the detailed review comments. This is exactly what’s needed for foundational material. Thanks for taking the time. |
RyanJK5
approved these changes
Jul 26, 2026
RyanJK5
left a comment
RyanJK5
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me now, thanks for making those changes!
Replaces -DXYZ_PROTOCOL_BUILD_REFLECTION_TUTORIAL=ON as the way to opt into building and testing tutorials/3_reflection.cc.
Twon
reviewed
Jul 28, 2026
Twon
reviewed
Jul 29, 2026
Twon
reviewed
Jul 29, 2026
Twon
reviewed
Jul 29, 2026
Twon
reviewed
Jul 29, 2026
Twon
reviewed
Jul 29, 2026
Twon
reviewed
Jul 29, 2026
…nto a signature-string example with a real multi-parameter case - Prefer std::ranges::range auto / std::ranges::views::filter over raw loops where the tutorial's own facilities allow it. - Section 5 was bundling two unequal helpers: a mostly-redundant find-by-name filter and the actually-new signature-string builder. Folded the name filter's only new content (is_const) into section 4, where it fits as a natural extension of the existing enumeration example, and narrowed section 5 to what's genuinely new: reading a member's parameters and rendering them as a signature string. - Widget in section 5 now has a real multi-parameter overload (write(int, double)), so the comma-join logic in simple_signature_string is actually exercised by a test, not just present in the code.
jbcoe
marked this pull request as draft
August 12, 2026 22:41
jbcoe
changed the title
Owner
Author
|
I'm going to re-work these tutorials to make them more focused. |
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure that these tutorials are necessary.
The act of writing them was useful and perhaps they will be useful to readers of the (increasingly novel and technical) code in #95.