Skip to content

Add infrastructure for C++26 compiler support (GCC16) - #152

Open
jbcoe wants to merge 6 commits into
mainfrom
cpp26-infra
Open

Add infrastructure for C++26 compiler support (GCC16)#152
jbcoe wants to merge 6 commits into
mainfrom
cpp26-infra

Conversation

@jbcoe

@jbcoe jbcoe commented Aug 18, 2026

Copy link
Copy Markdown
Owner

No description provided.

@jbcoe
jbcoe requested a review from Twon August 18, 2026 09:51

@Twon Twon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few minor comments but nothing major

Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt
Comment thread cmake/xyz_add_test.cmake
@jbcoe

jbcoe commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

Looks good, a few minor comments but nothing major

I guess in general we want noisy failure when reflection is not supported rather than silent fallback. Can I change the CMake setup to ensure this?

Comment thread CMakeLists.txt
@Twon

Twon commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Looks good, a few minor comments but nothing major

I guess in general we want noisy failure when reflection is not supported rather than silent fallback. Can I change the CMake setup to ensure this?

I think the fatal error is sufficient once we avoid specific compiler flags or restrict them to the appropriate compiler, as then we avoid failures due to using an unsupported flag and as then it should just work as future compilers add support.

@jbcoe
jbcoe force-pushed the cpp26-infra branch 2 times, most recently from 49c669e to 889c16b Compare August 18, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants