Fix reading resume after jumping ahead in an article - #10
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
After jumping two paragraphs ahead while listening, reopening the article could resume at the wrong place.
Resume rewound to the beginning of the sentence, a rewind to audio frame zero could retain an older checkpoint, and missing word timestamps in an earlier speech section could prevent accurate mapping in later sections.
This change restores the unfinished word at its original position in the article, including after a paragraph jump.
Changes
Validation
git diff --check.The Chrome check uses synthetic PCM, a controlled extension port, and the actual bundled reading-list store persisted across reloads.
Installed-extension worker behavior and live Fish Audio playback still need a manual check.
Validation details are recorded in
tests/PLAYBACK_VALIDATION.md.Manual check