Retry transient upload failures instead of aborting the whole sync - #171
Open
thefnox wants to merge 1 commit into
Open
Retry transient upload failures instead of aborting the whole sync#171thefnox wants to merge 1 commit into
thefnox wants to merge 1 commit into
Conversation
Roblox's edge proxy intermittently rejects valid upload requests with an
HTML 400 page ("Your browser sent an invalid request") before they reach
the Assets API. Previously any non-200/non-429 response set the global
fatally_failed flag, which aborted every other in-flight upload and
operation poll - discarding uploads that had already succeeded server-side
and leaving their asset ids out of the lockfile (orphaning the assets).
Now:
- Connection errors, 5xx responses, and proxy-level HTML 400s retry with
exponential backoff (up to the existing 5-attempt cap).
- Only 401/403 set the global fatal flag, since a bad or underprivileged
API key genuinely dooms every request.
- Other failures (e.g. real 400s from the API) fail only their own asset,
letting the rest of the sync finish and persist.
Co-Authored-By: Claude Fable 5 <[email protected]>
thefnox
force-pushed
the
fix/transient_upload_failures
branch
from
August 15, 2026 11:40
2fa8d7a to
208d54e
Compare
thefnox
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.