wrap-up: site-copy session findings — deck write guard, probe traps - #93
Merged
Merged
Conversation
…raps, shell trap Four findings from the session that shipped the site copy (youcoded #471, this workspace #92), landed where the next session reads them. - roadmap (dev-workspace, rigs): a stale review-deck page can overwrite <stem>.answers.json — deck/serve.py writes it on every POST with no guard, and that is the bug just fixed in site-copy-editor.py, where it erased a finished set of Destin's edits. The deck is the surface he answers every UI review on, so the same accident there loses answers. rotate_submitted covers only the already-submitted case. - scripts/ui-probe.mjs header: the three shapes that make a live-site probe read wrong — scrollTo/scrollIntoView do nothing on a body with `overflow: hidden auto`; intro-revealed sections sit at opacity 0 until their IntersectionObserver fires; the gallery and loops are lazy. Cost ~12 probe calls and one blank screenshot nearly reported as a rendering bug. - docs/wrap-ups.md: the session's entry, including the destructive-copy mistake (copying a file into a worktree copies the SHARED checkout's version, and `git checkout --` then discards a sibling session's uncommitted edits) and that the old session branch was 42 commits behind when wrap-up edits were attempted. The `pkill -f` self-match (it killed my own shell and silently skipped a commit) went to ~/system/tools/claude-code-bash-shell.md, which is outside this repo. Submitted via YouCoded Assistant
…site-copy-wrapup # Conflicts: # docs/wrap-ups.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session findings from shipping the site copy (youcoded #471, workspace #92), landed where the next session reads them.
dev-workspace.md→ rigs): a stale review-deck page can overwrite<stem>.answers.json—deck/serve.pywrites it on every POST with no guard. That is the bug just fixed insite-copy-editor.py, where it erased a finished set of Destin's edits; the deck is the surface he answers every UI review on, so the same accident there loses review answers.rotate_submittedcovers only the already-submitted case.scripts/ui-probe.mjsheader: the three shapes that make a live-site probe read wrong —scrollTo/scrollIntoViewdo nothing on a body withoverflow: hidden auto; intro-revealed sections sit atopacity: 0until their IntersectionObserver fires; the gallery and loops are lazy. Cost ~12 probe calls and one blank screenshot nearly reported as a rendering bug.docs/wrap-ups.md: this session's entry, including the destructive-copy mistake (git checkout --in the shared checkout can discard a sibling session's uncommitted work) and that the old session branch was 42 commits behind when wrap-up edits were attempted.Docs, roadmap and one tool comment — no app code.
roadmap-checkand the workspace unit tests pass. Merged current master in; the only conflict was two sessions appending a ledger entry, resolved by keeping both.The
pkill -fself-match (it killed my own shell and silently skipped a commit) went to~/system/tools/claude-code-bash-shell.md, outside this repo.Submitted via YouCoded Assistant