Implement Ito v1 local teleoperation loop - #5
Conversation
2f25156 to
b26a8a4
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f25156c70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| networks: | ||
| default: | ||
| name: podman | ||
| external: true |
There was a problem hiding this comment.
When a user follows the documented Docker path (docs/local-v1.md still starts with docker compose up --build ito-server pilot-client) on a clean Docker install, this makes the default network depend on a pre-existing network literally named podman. Docker's Compose docs say external networks are not created by Compose and up fails if they are missing (https://docs.docker.com/compose/how-tos/networking/), so the Docker flow now stops before the server/client can start unless the user manually creates a Podman-named Docker network. Keep the normal Compose-created default network, or move this Podman-specific network into an override file.
Useful? React with 👍 / 👎.
| - ito-server | ||
| environment: | ||
| ITO_SERVER_URL: ws://ito-server:8765 | ||
| ITO_SERVER_URL: ws://host.containers.internal:8765 |
There was a problem hiding this comment.
When the mock profile is run with Docker, the mock driver now connects to Podman's host.containers.internal name instead of the Compose service DNS name that Docker provides for ito-server. Docker's host-service documentation lists host.docker.internal for host access (https://docs.docker.com/desktop/features/networking/networking-how-tos/), and this compose file has no extra_hosts or Docker override for host.containers.internal, so after the network issue is addressed the documented Docker mock command will still leave the robot unable to register and reconnecting forever. Keep ws://ito-server:8765 for Docker or make the Podman hostname an override/env default.
Useful? React with 👍 / 👎.
1 participant
Summary
What works locally
Still intentionally out of scope / blocked
Test plan
pytest -q→ 41 passed, 1 skippedcd client && npm test→ 15 passed/tmp/ito-test-venv/bin/python -m pytest -q→ 42 passedpodman build -f server/Dockerfile -t ito-server:test .podman build -f drivers/mock-robot/Dockerfile -t ito-mock-robot:test .podman build -f drivers/ito-droid/Dockerfile -t ito-droid:test .