Skip to content

Build failure at merge commit of PR 84 #89

Open
Open
Build failure at merge commit of PR 84#89
Assignees
SimonPinches

Description

@Louwrensth
Louwrensth
opened on Oct 8, 2026

Recently, this PR was merged:

Before the merge commit, there were no failures detected on CI and it seemed ok to merge.

However, when GHA ran on the merge commit e76ebf2, there were issues detected:

Image

Could it have been prevented?

Activity

  1. olivhoenen
    assigned
    SimonPinches
    on Oct 8, 2026

  2. Louwrensth commented on Oct 8, 2026

    @Louwrensth
    Louwrensth
    on Oct 8, 2026
    CollaboratorAuthor

    I'm sorry, but this is bothering me 😄 -- It is still very strange to me, how it was not detected on @SimonPinches' own commit? Before the merge, he had rebased it onto a modern develop, so there is nothing new coming in from develop at this point.

    $ git lol -4 develop
*   e76ebf2b (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #84 from SimonPinches/fix/portable-pc-linker-flag
|\  
| * 31903383 Emit --defsym version stamp in al-core.pc only on supported linkers
|/  
* b2066738 Bump pypa/cibuildwheel from 4.1.1 to 4.2.0 in the actions-deps group
* de97f574 added error and their labels page

    Furthermore, once @olivhoenen hit the merge button, it still reported all green at the merge commit e76ebf2 ! ✔️

    Image

    But clicking on that same commit e76ebf2 it actually shows the five red crosses ❌

    😠 I'm gravitating to blaming GitHub.

  3. SimonPinches commented on Oct 8, 2026

    @SimonPinches
    SimonPinches
    on Oct 8, 2026
    Contributor

    See PR #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions