Repository navigation
3.4.0 phase 1: integration branch shared/340-20261027 (CI only, not for merge) - #10
Merged
Merged
Conversation
The publish job attaches the archives to the GitHub release within the run, and the release page is where they live afterwards; the workflow artifacts were kept 90 days by default and accumulated across releases (48 live) in the organisation's artifact storage, which hit its quota (superproject issue QB-1164). A week covers a re-run of the publish job alone.
Built through add_subdirectory with QB_EV_EMBED_INCLUDE_DIR set -- the way qb builds it -- every function and variable the library exports links as qb_ + its libev name (qb_ev_run), and wepoll's five functions as qb_ev_epoll_* inside the library's own translation units on Windows. The generated ev_config.h, which ev.h includes before it declares anything, carries one #define per name, so source keeps libev's spelling. The list sits beside QB_EV_EXPORTED_NAMES in CMakeLists.txt: every name ev.h declares with EV_API_DECL / EV_API_DATA_DECL, but ev_rt_now, which ev.h exports only without EV_MULTIPLICITY and which ev.c defines as a loop member under it. Before, qb's copy and any other libev in the same program shared every link name and the link line chose between them. Measured on ld64: a foreign libev first on the line made qb's loop call the foreign ev_loop_new, behind a duplicate-symbol warning and a linker exit of 0. A standalone build is unchanged: its ev_config.h says it keeps libev's own names, and its archive exports what it did. Both files stay byte-identical with qb/src/qb/ev, the source of truth.
|
Connected to Huly®: QB-1167 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, not for merge: the 3.4.0 phase-1 integration branch, opened so the CI lanes run on each tip of shared/340-20261027 (they trigger on pull requests into develop). develop moves only at the phase-exit gate, by fast-forward after the full gate on the tip; coordination on Huly QB-1143.