Skip to content

Fix duration parsing and exclusive pagination bounds - #2

Closed
soundcake wants to merge 3 commits into
isearchxsolve:mainfrom
soundcake:bounty/duration-case-validation
Closed

soundcake wants to merge 3 commits into
isearchxsolve:mainfrom
soundcake:bounty/duration-case-validation

Conversation

@soundcake

@soundcake soundcake commented Oct 29, 2026 •

Copy link
Copy Markdown

Closes #1.
Closes #3.

Duration parsing now accepts uppercase and mixed-case units and raises ValueError when the input contains no supported duration group. Valid zero durations remain supported.

Pagination now returns an exclusive end bound, so full pages include their last item. Regression coverage includes first, second, partial and single-item pages.

Validation on Python 3.12 against upstream 0bdb8b7:

  • make build passes.
  • make lint passes.
  • make test passes all 10 tests.

The unmodified upstream suite reproduced four failures; the duration fix alone left the two full-page pagination failures, which the pagination fix resolves.

@soundcake soundcake changed the title Fix case-insensitive duration parsing and invalid input Fix duration parsing and exclusive pagination bounds Oct 29, 2026
@isearchxsolve

Copy link
Copy Markdown
Owner

This repository is a private pipeline test fixture. The issue is a fixed test case, not open work, and unsolicited PRs are not accepted. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parse_duration ignores uppercase units and returns 0 for invalid input page_bounds drops the last item of every full page

2 participants