Add content error for unset sig figs bounds - #822
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
=======================================
Coverage 41.00% 41.00%
=======================================
Files 550 550
Lines 23602 23606 +4
Branches 2848 2851 +3
=======================================
+ Hits 9678 9680 +2
- Misses 13052 13054 +2
Partials 872 872 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| if (null == q.getSignificantFiguresMin() && null == q.getSignificantFiguresMax()) { | ||
| this.registerContentProblem(content, "Numeric Question: " + q.getId() + " has no " | ||
| + "significant figure bounds set. If this question does not use significant figures then " | ||
| + "'exact answers only' should be set.", indexProblemCache); |
There was a problem hiding this comment.
Is there any reason why this isn't also being applied to coordinate questions? As far as I can tell, they have the same behaviour on a significant figure not being set, so they ought to have the same error! (If it's just because it wasn't requested, then I request it instead).
Similarly, the 'one significant figure' bound message is different for the two question types, but I'm not sure why.
and may be unanswerable as a result. Please add both upper and lower significant figure bounds, or set 'exact answers only'.Sig figs will be ignored for this question; add both min and max to fix this.
I prefer the former one - I think it's more accurate.
If there IS a reason for these differences, then this is fine. The content error works.
There was a problem hiding this comment.
No reason as far as I know; bizarrely the "...has broken significant figures rules" error message has been copy & pasted between the two question types, it's just the first error message that is different 🤷 I'll copy the numeric q feedback over to coord qs; given we're only using it twice, I don't think it's worth introducing a constant for consistency.
We're also not currently checking for disregardSignificantFIgures before performing sig fig bounds checks for coord qs. That might as well be made consistent with numeric qs, too.
2 participants
No description provided.