Use SetBuilder for batched gNMI operations in NX-OS provider - #463
Open
felix-kaestner wants to merge 1 commit into
Open
Use SetBuilder for batched gNMI operations in NX-OS provider#463felix-kaestner wants to merge 1 commit into
felix-kaestner wants to merge 1 commit into
Conversation
Replace the per-method Update/Patch/Delete slice accumulation with SetBuilder throughout the NX-OS provider. Each Ensure* and Delete* method now builds a single SetBuilder and calls p.Do, which handles the NX-OS feature-ordering constraint transparently via Split. This reduces gNMI Set round-trips for mixed-operation methods (EnsureInterface, EnsurePIM, EnsureBorderGatewaySettings, etc.) from 2-3 RPCs to 1 (or 2 on NX-OS <= 10.6(2) with features). Add maxSetOperations constant (20) as the default batch limit. Remove the now-unused p.Update, p.Patch, and separateFeatureActivation helpers. Signed-off-by: Felix Kästner <[email protected]>
felix-kaestner
force-pushed
the
gnmiext/use-setbuilder
branch
from
July 27, 2026 09:08
e274257 to
8056777
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the per-method Update/Patch/Delete slice accumulation with
SetBuilder throughout the NX-OS provider. Each Ensure* and Delete*
method now builds a single SetBuilder and calls p.Do, which handles
the NX-OS feature-ordering constraint transparently via Split.
This reduces gNMI Set round-trips for mixed-operation methods
(EnsureInterface, EnsurePIM, EnsureBorderGatewaySettings, etc.)
from 2-3 RPCs to 1 (or 2 on NX-OS <= 10.6(2) with features).
Add maxSetOperations constant (20) as the default batch limit.
Remove the now-unused p.Update, p.Patch, and
separateFeatureActivation helpers.