Repository navigation
Fix/viewer replay egress tuning - #16
Merged
Merged
Conversation
…ostics A viewer that fell behind could bank multiple seconds of publisher-ring backlog and then burst it out (MAX_EGRESS_BATCHES=8, ~20x realtime), which a viewer perceives as a jump back then skip forward. Treat the ring as a hand-off buffer, not a jitter buffer: size it at 1x the latency window (was 2x) and drain at most 2 batches per egress pass (was 8), so a viewer that falls behind is skipped forward per packet by SRT TLPKTDROP at the socket instead of catching up on a burst of stale frames. The SRT socket holds each viewer's latency window. Also add per-stream observability for this class of issue: - /stats maxReaderBacklogBytes / maxReaderBacklogMs (furthest any viewer fell behind the ring write head). - fix sendBackpressure, which was read off the publisher role (which never runs the egress write path) and so was structurally always 0; now aggregated across a stream's viewers via the shared ring. - stream=<name> on teardown log lines for grep, plus a publisher session-end flight-recorder line that survives publisher reconnect.
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.