Repository navigation
Stub blob URLs unconditionally, so the vitest 5.0.1 + jsdom 30.1 pair cannot break the configurator tests - #114
Merged
Merged
Conversation
… a field jsdom 30.1 renamed #110 (the frontend patch group), rebased onto the fixed main, still failed `Tests`: 24 configurator cases with `TypeError: Cannot read properties of undefined (reading '_buffer')` out of `URL.createObjectURL`. Vitest 5.0.1's jsdom compatibility layer builds a Node Blob from jsdom's private `_buffer`; jsdom 30.1 renamed it (vitest-dev/vitest#11336, fixed upstream by #11295, unreleased). `vitest.setup.ts` already had a counter-based double, guarded by "only if nothing provides one" - and vitest 5.0.1 provides one, so the guard handed the tests the broken implementation. The guard is gone. No test dereferences the URL: the 3D view's loader fails on `blob:test/N` and settles as `failed`, exactly as under vitest 4 when the double was all there was, and no test asserts a rendered mesh. Verified from #110's lockfile (jsdom 30.1.0, vitest 5.0.1, react 19.3.0): 24 failed before, 25 passed after in ConfiguratorPage.test.tsx; then `tsc --build --force`, `lint`, `test` (33 files, 317 passed) and `build` each exit=0. Re-verified on main's lockfile (jsdom 30.0.1, vitest 5.0.0): 317 passed. Co-Authored-By: Claude Fable 5.1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks #110. Rebased onto the fixed
main, the frontend patch group still failedTests: 24 configurator cases withTypeError: Cannot read properties of undefined (reading '_buffer')fromURL.createObjectURL. Vitest 5.0.1's jsdom compatibility layer reads a private_bufferoff jsdom'sBlob; jsdom 30.1.0 renamed it. Upstream: vitest-dev/vitest#11336, fixed by #11295, unreleased. The two land together in #110 because Dependabot groups by semver, not by which packages share a private field — the same shape as the anyio / starlette pair in #112.frontend/vitest.setup.tsalready had a counter-basedcreateObjectURLdouble, guarded by "only if nothing provides one". Vitest 5.0.1 provides one, so the guard handed the tests the broken implementation. The guard is gone; the comment records why the double is the right thing regardless (no test dereferences the URL — the 3D view's loader fails on it and settles asfailed, as it did under vitest 4).Verified, from
npm cion #110's lockfile (jsdom 30.1.0, vitest 5.0.1, react 19.3.0):ConfiguratorPage.test.tsx24 failed before the change, 25 passed after; thentsc --build --force,lint,test(33 files, 317 passed) andbuildeachexit=0. Re-verified onmain's lockfile (jsdom 30.0.1, vitest 5.0.0): 317 passed. HANDOFF carries the record.After this merges:
@dependabot rebaseon #110.🤖 Generated with Claude Code