Repository navigation
fix(android): keep Firebase registrars from R8 - #145
Merged
Merged
Conversation
alexgerardojacinto
approved these changes
Oct 21, 2026
OS-ruimoreiramendes
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds firebase-components 18.0.1's keep rule to the plugin's
proguard-rules.pro, and wires the file throughconsumerProguardFilesandfilesso it reaches apps.ML Kit barcode scanning 17.3.0 brings firebase-components 16.1.0, whose own rule keeps
ComponentRegistrarclasses but not their constructors. AGP 9 no longer keeps those, so with R8 on ML Kit's components fail to register and decoding throws.Tested on Capacitor 9.0.0-alpha.8 with R8 on, in an app where this is the only ML Kit or Firebase user. ML Kit decodes a QR code as with R8 off. With
next, three registrars fail to load and decoding throws aNullPointerException.Logs
With
next:With this branch:
Change Type
Rationale / Problems Fixed
https://outsystemsrd.atlassian.net/browse/RMET-5542
Platforms Affected
Notes
The rule does nothing once firebase-components 18.0.1 or later is resolved.