Repository navigation
refactor(catalog): read bundled extension specs through embeddedspecs.Parse - #641
Merged
Merged
Conversation
….Parse parseCatalog was the third copy of the read, decode, reject-duplicate, sort loop that internal/embeddedspecs owns. It now calls Parse with checkProcessSource as the check, and Entry becomes an alias of embeddedspecs.Entry[extension.Spec], as in dependency and playbook. The exemption for parseCatalog in the embeddedspecs gate is deleted, so the gate now has no exempt functions. Signed-off-by: Ion Alpha <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
extension/catalog.parseCatalognow callsembeddedspecs.ParsewithcheckProcessSourceas the check, andEntrybecomes an alias ofembeddedspecs.Entry[extension.Spec], the same shapedependencyandplaybookuse. TheparseCatalogexemption in the embeddedspecs gate is deleted, so the exempt list is empty.Why
parseCatalogwas the third copy of the read, decode, reject-duplicate, sort loop thatinternal/embeddedspecsowns (#603). The gate carried an exemption for it with a note that it would move in its own change; this is that change.How to verify
Run
go test ./extension/... ./internal/embeddedspecs/. The existingTestParseCatalogErrorPathsand the source tests pass unchanged, and the gate's liveness check would fail if the exemption were still listed. Error messages are identical: the prefix iscatalogand the duplicate message readscatalog: duplicate official extension name %q../dev/checkis green through build, vet, race tests, lint and tidy; the local govulncheck and osv steps fail on the local toolchain and an unrelated x/crypto advisory.