Repository navigation
fix: save timeout inputs as solutions - #393
Merged
Merged
Conversation
The objective used TimeFeedback, which never reports an input as interesting, so timeouts were only logged and never written to the solutions directory. Hanging inputs with new coverage were added to the corpus instead. Use TimeoutFeedback, which flags ExitKind::Timeout. The timeout test now seeds a hanging input and asserts it lands in solutions. Fixes intel#392 Co-authored-by: Claude <[email protected]>
The x86_64_manual tests called fuzz.stop() on magic 2, but the harness stop is N_STOP_NORMAL (4), so every iteration ended in a timeout. Now that timeouts are solutions, no input reached the corpus and the fuzzer aborted with 'No interesting cases found from inputs'. Also drop the duplicated on_magic definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #392
Summary
The objective chain used
TimeFeedback, whoseis_interestingalways returnsfalse(it only stamps exec time as metadata). SoExitKind::Timeoutnever reached the solutions corpus: timeouts were only logged, and hanging inputs with new coverage were added to the corpus instead, where the fuzzer kept re-running them.objective = feedback_or_fast!( CrashFeedback::new(), - TimeFeedback::new("time"), // never interesting + TimeoutFeedback::new(), // interesting on ExitKind::Timeout )The
TimeFeedbackin the normal feedback chain (exec-time metadata) stays. The now-unusedTIMEOUT_FEEDBACK_NAMEconstant is removed.x86_64_edk2_timeout_{latest,6_0_185}previously asserted nothing. They now seed the corpus withA(the harness stalls 10s, over the 3s timeout) andD(normal, so the corpus isn't empty), then assert thatsolutions/holds at least one input and that every solution starts withA.Evidence
cargo test -r --test x86_64_edk2_timeout_latest(Simics 7.70.0, QSP-x86 7.48.0):Merge Danger
Door: two-way
Blast Radius: fuzzing campaigns
solutions/and in theobjectivescount, and no longer enter the corpus. Campaigns with a tighttimeoutwill report more solutions.Timeout input for AFL indices ...log line no longer fires. It is replaced by the LibAFL[Objective #N]monitor line, which is the same behavior crash solutions already have._6_0_185variant was updated identically but only the_latestvariant was run.