Bug fix in loadMemString for unaligned sections - #293
Merged
Conversation
mkorbel1
requested changes
Jul 1, 2026
mkorbel1
left a comment
mkorbel1
left a comment
Contributor
There was a problem hiding this comment.
Looks great once you add a unit test, thanks for catching and fixing!
mkorbel1
approved these changes
Jul 1, 2026
mkorbel1
left a comment
mkorbel1
left a comment
Contributor
There was a problem hiding this comment.
Looks great to me, thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
loadMemStringhas a bug when there is a discontinuity at a start address that is not aligned with the word size where it is possible for data to get squashed.Related Issue(s)
N/A
Testing
Confirmed in user environment and will add a unit test.
Backwards-compatibility
Backwards compatible as this is a bug fix.
Documentation
N/A