fix: Strip host-write-only flag and cover all capture-replay allocations - #486
Merged
Merged
Conversation
Capture/replay needs to read buffer and image contents back on the host to dump and replay kernels, so CL_MEM_HOST_WRITE_ONLY must be cleared alongside CL_MEM_HOST_NO_ACCESS. Also apply the same flag masking to clCreateBufferWithProperties, clCreateImage, and clCreateImageWithProperties, which were previously missing it.
bashbaug
approved these changes
Sep 7, 2026
bashbaug
left a comment
bashbaug
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your contribution!
At some point we should factor this into a helper function / macro, but that can happen in a different PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CaptureReplayneeds to read back buffer/image contents on the host to dump and replay kernels, soCL_MEM_HOST_WRITE_ONLYmust be cleared in addition toCL_MEM_HOST_NO_ACCESS.clCreateBuffer) toclCreateBufferWithProperties,clCreateImage, andclCreateImageWithPropertieswhich were previously missing it.Fixes
CLUMD's internal sanity test copybuf_test wasn't being replayed properly as the capture was missing source data.
Testing Done