Support BGGR/RGGB/GBRG bayer orders in the PSYS pipeline - #182
Open
dmanresa-saes wants to merge 1 commit into
Open
Support BGGR/RGGB/GBRG bayer orders in the PSYS pipeline#182dmanresa-saes wants to merge 1 commit into
dmanresa-saes wants to merge 1 commit into
Conversation
The HAL only handles GRBG (and bare RAW) bayer input in three places,
which breaks any sensor whose readout produces another bayer order:
- PGUtils::getStride() falls through to a stride that violates the
terminal requirements for 10-bit bayer, and the program group aborts
with a firmware assert in dma_nci_io (stride % 64).
- CameraUtils::getBpl() does not know the BG10/RG10/GB10 fourccs and
returns a wrong bytes-per-line, producing a vertically striped image.
- PipeLiteExecutor::isSameStreamConfig() rejects the external SBGGR10/12
stream against the internal SGRBG10/12 one, so the input ports never
bind ("Failed to bind input ports").
Add the missing bayer orders next to the existing GRBG cases. Verified
on a Surface Pro 7+ (IPU6 Tiger Lake) front OV5693, which advertises
SBGGR10 in its 2x2-binned mode: with these three changes the full
sensor -> ISYS -> PSYS pipeline runs at 30 fps.
Signed-off-by: D. Manresa <[email protected]>
Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HAL currently only handles GRBG bayer input in three spots, which breaks any sensor advertising another bayer order. We hit this bringing up the Surface Pro 7+ front camera (OV5693, SBGGR10 in its 2x2-binned mode) on the mainline
intel-ipu6ISYS:PGUtils::getStride()— unknown bayer formats fall through to an unaligned stride and the PG aborts with a firmware assert indma_nci_io(stride % 64).CameraUtils::getBpl()—BG10/RG10/GB10fourccs missing → wrong bytes-per-line → vertically striped image.PipeLiteExecutor::isSameStreamConfig()— the SBGGR external stream never matches the internal SGRBG one, so input ports fail to bind.This adds the missing bayer orders alongside the existing GRBG cases (no behavior change for currently supported sensors). Verified end-to-end on a Surface Pro 7+ (IPU6 Tiger Lake): with these three changes the full sensor → ISYS → PSYS pipeline runs at 30 fps with correct output. Full bring-up documented at https://github.com/dmanresa-saes/surface-ipu6-cameras.