test(many): add missing await on userEvent calls in vitest#2644
Open
ToMESSKa wants to merge 1 commit into
Open
test(many): add missing await on userEvent calls in vitest#2644ToMESSKa wants to merge 1 commit into
ToMESSKa wants to merge 1 commit into
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
ToMESSKa
commented
Jul 17, 2026
|
|
||
| await waitFor(() => { | ||
| expect(onChange).not.toHaveBeenCalled() | ||
| expect(onChange).toHaveBeenCalledWith(['tester', 'test-value-1']) |
Contributor
Author
There was a problem hiding this comment.
A controlled CheckboxGroup is supposed to fire onChange on every click (that's how it reports the user's intent to the parent) — it just never changes its own checked state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-5100
ISSUE:
TEST PLAN: