Skip to content

feat(workflow): add Rust paperclip-qa-file-owner helper, parity suite, and CI gate - #769

Merged
insightflo merged 4 commits into
mainfrom
feat/rust-qa-file-owner-20261118
Nov 18, 2026
Merged

insightflo merged 4 commits into
mainfrom
feat/rust-qa-file-owner-20261118

Conversation

@insightflo

Copy link
Copy Markdown
Owner

Summary

  • Add crates/qa-file-owner (paperclip-qa-file-owner), a 1:1 drop-in Rust replacement for server/src/services/workflow/control-flow/qa-remediation-file-owner.py (v=1 stdio JSONL protocol, flock(LOCK_EX) with lock_wait, lstat/fstat guard inode verification, preflight validation across all targets prior to mutation, atomic temp/fsync/fchmod/rename/readback/dir-fsync, exit codes 0/2/3, positional legacy .py argv ignored for zero-change TS compatibility via PAPERCLIP_QA_FILE_OWNER_PYTHON).
  • Keep all source, test, workflow, and manifest files strictly <= 300 lines per AGENTS.md Rule 8 (zero Rule 8 exceptions):
    • src/: main.rs (198), protocol.rs (203), guard.rs (285), publish_io.rs (243), publish.rs (197)
    • tests/: common/mod.rs (225), guard_locking.rs (242), publication.rs (176), protocol_framing.rs (156) using native CARGO_BIN_EXE_paperclip-qa-file-owner
    • TS parity test: server/src/__tests__/qa-remediation-file-owner-rust-parity.test.ts (232) exercising createQaFileOwnerRuntime, QaRemediationFileOwner, runGuardedPublication, lock_wait, SIGKILL recovery, and raw Python↔Rust refusal parity
    • CI: .github/workflows/pr.yml (294 lines, trimmed from 303) adding dtolnay/rust-toolchain@stable (clippy + cargo test --release) in heavy policy and dtolnay/rust-toolchain@stable in verify-tests without duplicating scripts/ci-scope.sh rules

Verification

  • cargo clippy --manifest-path crates/qa-file-owner/Cargo.toml --all-targets -- -D warnings: 0 warnings
  • cargo test (debug) & cargo test --release: 27/27 passed (2 unit + 9 guard_locking + 11 protocol_framing + 5 publication)
  • pnpm -r typecheck & check:write-chokepoint & check-dockerfile-deps-stage.sh: exit 0
  • Vitest (qa-remediation-file-owner*.test.ts + ci-scope-script.test.ts): 4 files / 53 tests passed
  • Node↔Rust release latency benchmark (50 iterations): Rust 5.02 ms mean vs Python3 44.26 ms mean (8.81x speedup; zero TS wrapper changes)
  • Independent review (w-agy / gemini-4-hydrogen-xhigh): PASS (0 BLOCKER, 0 MAJOR, full Rule 8 compliance)

Rollout Note

  • Existing default runtime remains Python 3 unless PAPERCLIP_QA_FILE_OWNER_PYTHON points to the compiled paperclip-qa-file-owner binary (1-line opt-in / instant rollback).

@insightflo insightflo added the ci-full PR CI: run the full suite (verify + verify-tests shards + e2e) on this PR label Nov 18, 2026
@insightflo
insightflo force-pushed the feat/rust-qa-file-owner-20261118 branch from 0e85f53 to 857b28b Compare November 18, 2026 07:08
@insightflo insightflo removed the ci-full PR CI: run the full suite (verify + verify-tests shards + e2e) on this PR label Nov 18, 2026
@insightflo
insightflo merged commit 72308e1 into main Nov 18, 2026
6 checks passed
@insightflo
insightflo deleted the feat/rust-qa-file-owner-20261118 branch November 18, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant