Skip to content

fix(antigravity-local): remove 180s printTimeout cutoff and align permission/sandbox/monitor handling - #766

Merged
insightflo merged 1 commit into
mainfrom
fix/antigravity-timeout-and-safety
Nov 18, 2026
Merged

insightflo merged 1 commit into
mainfrom
fix/antigravity-timeout-and-safety

Conversation

@insightflo

Copy link
Copy Markdown
Owner

Summary

Diagnosed and fixed why antigravity_local runs failed after switching to explicit models (e.g. gemini-4-hydrogen-high / gemini-4-argon-medium):

  1. Remove hardcoded 180s --print-timeout cutoff:
    • ui/build-config.ts hardcoded ac.printTimeout = "180s" and execute.ts defaulted to 180s, ignoring Timeout (sec) (config.timeoutSec) and killing multi-turn runs with DEADLINE_EXCEEDED at 3 minutes.
    • Added resolveAntigravityPrintTimeout() to honor explicit printTimeout / printTimeoutSec, inherit positive timeoutSec, yield to --print-timeout in extraArgs, and otherwise default to 0s (unbounded turn wait, matching agy CLI default and other local adapters' timeoutSec = 0).
    • Updated buildAntigravityLocalConfig to set timeoutSec = 0 instead of printTimeout = "180s", and exposed Print timeout in AntigravityLocalAdvancedFields so existing saved 180s values are visible and editable in the UI.
  2. Fix dangerouslySkipPermissions and sandbox UI/runtime mismatches:
    • execute.ts previously read bypassPermissions before dangerouslySkipPermissions, silently ignoring Edit-UI toggles when bypassPermissions: false remained from agent creation. Added resolveAntigravityBypassPermissions() preferring canonical dangerouslySkipPermissions.
    • Aligned AntigravityLocalAdvancedFields Enable sandbox default check to config.sandbox === true (matching runtime asBoolean(config.sandbox, false) instead of !== false).
  3. Mitigate & surface Antigravity safety-monitor (sir_flash_lite) denials:
    • Added concise headless agy --print execution notes warning agents against raw env dumps (PAPERCLIP_API_KEY Signal D trigger) and unnecessary BypassSandbox: true requests when --sandbox is disabled (which trigger interactive ask prompts auto-denied in headless mode).
    • Added extractAntigravityMonitorDenial() in resolveAntigravityFailure() to report Monitor ... FINISHED: triggered=true reasons instead of generic empty-response errors.

Note: Google's agy binary enforces its internal sir_flash_lite safety monitor even under --dangerously-skip-permissions; Paperclip does not bypass it and improves compatibility via timeout/flag alignment, guidance, and failure diagnostics.

Verification

  • pnpm --filter @paperclipai/adapter-antigravity-local build && typecheck
  • npx vitest run packages/adapters/antigravity-local (3 files, 27 tests passed)
  • npx vitest run server/src/__tests__/antigravity-local-adapter-environment.test.ts server/src/__tests__/antigravity-models.test.ts ui/src/components/AgentConfigForm.model-dropdown.test.tsx (3 files, 14 tests passed)
  • pnpm --filter @paperclipai/ui typecheck & pnpm --filter @paperclipai/server typecheck & pnpm run check:write-chokepoint

@insightflo
insightflo merged commit adaf331 into main Nov 18, 2026
6 checks passed
@insightflo
insightflo deleted the fix/antigravity-timeout-and-safety branch November 18, 2026 01:55
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

🔍 OpenCodeReview found 2 issue(s) in this PR.

  • ✅ Successfully posted inline: 2 comment(s)

Comment on lines 64 to 70
: eff(
"adapterConfig",
"dangerouslySkipPermissions",
config.dangerouslySkipPermissions === true || config.bypassPermissions === true,
typeof config.dangerouslySkipPermissions === "boolean"
? config.dangerouslySkipPermissions
: config.bypassPermissions === true,
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style · low
중첩 삼항 연산자가 사용되었습니다 (isCreate 삼항식 내부에 typeof 체크 삼항식이 중첩). 프로젝트 규칙상 중첩 삼항식은 허용되지 않습니다. 레거시 폴백 로직을 컴포넌트 수준의 변수로 추출하면 가독성이 좋아지고, 서버 측 resolveAntigravityBypassPermissions와 동일한 우선순위 규칙(canaonical 필드 우선 → legacy bypassPermissions 폴백)을 미러링한다는 의도도 명확해집니다.

Suggestion:

Suggested change
: eff(
"adapterConfig",
"dangerouslySkipPermissions",
config.dangerouslySkipPermissions === true || config.bypassPermissions === true,
typeof config.dangerouslySkipPermissions === "boolean"
? config.dangerouslySkipPermissions
: config.bypassPermissions === true,
)
const skipPermissionsEffective =
typeof config.dangerouslySkipPermissions === "boolean"
? config.dangerouslySkipPermissions
: config.bypassPermissions === true;
return (
// ...
checked={
isCreate
? values!.dangerouslySkipPermissions
: eff("adapterConfig", "dangerouslySkipPermissions", skipPermissionsEffective)
}

Comment on lines +98 to +99
value={eff("adapterConfig", "printTimeout", String(config.printTimeout ?? ""))}
onCommit={(v) => mark("adapterConfig", "printTimeout", v.trim() || undefined)}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug · low
Print timeout 값이 검증 없이 그대로 커밋되며, 이후 resolveAntigravityPrintTimeout(packages/adapters/antigravity-local/src/server/args.ts)이 빈 문자열이 아닌 모든 문자열을 그대로 agy --print-timeout 값으로 전달합니다. 단위 없는 600, 10min, 5 minutes 같은 형식 오류 입력은 조용히 저장되고, 런타임에 CLI 파싱 실패라는 원인 파악이 어려운 형태로만 노출됩니다. 힌트에 명시된 형식(예: 0s, 600s, 10m)을 커밋 시점에 간단히 검증하거나, 단위 없는 숫자는 초 단위로 정규화하는 것을 권장합니다.

Suggestion:

Suggested change
value={eff("adapterConfig", "printTimeout", String(config.printTimeout ?? ""))}
onCommit={(v) => mark("adapterConfig", "printTimeout", v.trim() || undefined)}
value={eff("adapterConfig", "printTimeout", String(config.printTimeout ?? ""))}
onCommit={(v) => {
const trimmed = v.trim();
// 힌트에 명시된 형식(예: 0s, 600s, 10m)만 허용
if (trimmed && !/^\d+(\.\d+)?(ms|s|m|h)?$/.test(trimmed)) return;
mark("adapterConfig", "printTimeout", trimmed || undefined);
}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant