Repository navigation
Conversation
The link had the `{project_repo}` placeholder instead of the repo name, so
it did not resolve. From 20.0 the README is the module description and it is
exported to the translation files, so the placeholder would end up there too.
Re-export of the .pot and the es.po against 20.0, keeping the terms that the module already had translated. From 20.0 the export also brings the module card: the name is translated and the description, which is the whole README, is left untranslated on purpose. "Display Name" takes the wording the team fixed for the terms that the core translates in more than one way. The "Clasificacion ABC" entry stays empty because its source text is already in Spanish; it should be changed to English in the view.
Contributor
Author
|
Adversarial review of this migration, for the reviewer. The POS one is in the
|
Contributor
|
@roboadhoc r+ nobump rebase-ff |
|
Merge method set to rebase and fast-forward. |
roboadhoc
pushed a commit
that referenced
this pull request
Nov 11, 2026
Part-of: #159 Signed-off-by: Juan Carreras <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Nov 11, 2026
The link had the `{project_repo}` placeholder instead of the repo name, so
it did not resolve. From 20.0 the README is the module description and it is
exported to the translation files, so the placeholder would end up there too.
Part-of: #159
Signed-off-by: Juan Carreras <[email protected]>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Migration of
partner_sales_abcfrom 19.0 to 20.0.Tarea: https://www.adhoc.inc/odoo/project.task/76746
What changed
__manifest__.py: version to20.0.1.0.0, andinstallableback toTrue.Against
origin/19.0this is the only change the jump asked for:depends(
["contacts"]) andauto_installare untouched.README.rst: the Bug Tracker link had the{project_repo}placeholderinstead of the repo name, so it did not resolve. From 20.0 the README is the
module description and is exported to the translation files, so the
placeholder would end up there too.
i18n/:.potandes.pore-exported against 20.0, keeping the terms thatwere already translated. The module card is new in the 20.0 export: the name
is translated and the description, which is the whole README, is left
untranslated on purpose. "Display Name" takes the wording we fixed for the
terms that the core translates in more than one way.
Test plan
contactsand demo data.res.partner(
char), theclasificacion_abcgroup and the field are in the combinedarch of
base.view_partner_form, the group hangs off the singlesales_purchasespage, and the field writes and reads back.upgrade_code: the 10 scripts of the jump ran, 0 files modified.pre-commit run -a: clean.migrated without one, with the developer's OK.
jump yet, so this PR does not cover that either.
Known scope
In 19 the Point of Sale opened the customer form through an action that pointed
at
base.view_partner_form(point_of_sale/views/res_partner_view.xml, calledfrom
pos_store.js), so the ABC group showed up there. In 20 that action isgone:
res.partner.action_open_partner_viewreturnspoint_of_sale.view_partner_form_pos_ui, a primary form that does not inheritbase.view_partner_form, so the ABC group is not reachable from the POSscreen. There is no error and no failing test.
This PR does not change the module for it. Covering that form would add a
point_of_saledependency the module does not have, which would change thebases the module installs in, and whether the cashier needs the ABC
classification is a product decision. It is asked in the task. The only
productive base with this module does not have
point_of_saleinstalled.