Repository navigation
Conversation
- Bump version to 20.0 and mark the module installable (odoo-module-migrator). - Convert ir.model.access.csv to ir.access.csv (upgrade_code 19.4-00-ir-access). - Search view: the "type_company" filter no longer exists in base.view_res_partner_filter; anchor the state filters on "filter_vat_set", which sits in the same group.
|
|
The module gave every internal user read on the whole ir.model.fields table. The core does not (in 20 only base.group_erp_manager has it), and in 20 that exposes fields such as ai_fields prompt_custom. partner_state only reads res.partner fields, so the access gets that domain.
les-adhoc
changed the title
"Changes?" now only adds fields to the chatter. Fields that Odoo tracks by default are always tracked, with or without lines in Partner State Fields. Before, the _message_track override only logged the fields with "Changes?", so a database without lines logged no partner change. The "Changes?" column now shows a computed field: it is checked and read only for fields with native tracking, and it writes the stored value for the other fields. Existing lines show the right value without a migration. The README explains the options of Partner State Fields and lists the fields that Odoo tracks on contacts by default. In 19.0, also drop the unused initial_values and state_fields_to_track from write(). closes ingadhoc#156 X-original-commit: ed6f85d Signed-off-by: Matias Velazquez <[email protected]> Signed-off-by: Luciano Esperlazza <[email protected]> In 20.0, without mail_tracking the tracking is only rendered in the message body, so the test reads the field labels from there. The README also lists the related fields that 20 tracks with the name. Cherry-picked from ff015cb (19.0).
les-adhoc
force-pushed
the
20.0-t-76509-les
branch
from
October 21, 2026 16:08
45f97f7 to
3956f19
Compare
…e written values Without mail_tracking the test reads the logged labels from the message body. It now maps them against every field the model tracks, not only the written ones, so a field logged on top (a related field, or one that starts to be tracked natively) breaks the equality.
Contributor
|
@roboadhoc r+ rebase-ff |
Contributor
|
@roboadhoc nobump |
|
Merge method set to rebase and fast-forward. |
roboadhoc
pushed a commit
that referenced
this pull request
Nov 2, 2026
- Bump version to 20.0 and mark the module installable (odoo-module-migrator). - Convert ir.model.access.csv to ir.access.csv (upgrade_code 19.4-00-ir-access). - Search view: the "type_company" filter no longer exists in base.view_res_partner_filter; anchor the state filters on "filter_vat_set", which sits in the same group. Part-of: #154 Signed-off-by: Juan Carreras <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Nov 2, 2026
Part-of: #154 Signed-off-by: Juan Carreras <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Nov 2, 2026
The module gave every internal user read on the whole ir.model.fields table. The core does not (in 20 only base.group_erp_manager has it), and in 20 that exposes fields such as ai_fields prompt_custom. partner_state only reads res.partner fields, so the access gets that domain. Part-of: #154 Signed-off-by: Juan Carreras <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Nov 2, 2026
"Changes?" now only adds fields to the chatter. Fields that Odoo tracks by default are always tracked, with or without lines in Partner State Fields. Before, the _message_track override only logged the fields with "Changes?", so a database without lines logged no partner change. The "Changes?" column now shows a computed field: it is checked and read only for fields with native tracking, and it writes the stored value for the other fields. Existing lines show the right value without a migration. The README explains the options of Partner State Fields and lists the fields that Odoo tracks on contacts by default. In 19.0, also drop the unused initial_values and state_fields_to_track from write(). closes #156 X-original-commit: ed6f85d Signed-off-by: Matias Velazquez <[email protected]> Signed-off-by: Luciano Esperlazza <[email protected]> In 20.0, without mail_tracking the tracking is only rendered in the message body, so the test reads the field labels from there. The README also lists the related fields that 20 tracks with the name. Cherry-picked from ff015cb (19.0). Part-of: #154 Signed-off-by: Juan Carreras <[email protected]>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tarea: https://www.adhoc.inc/odoo/project.task/76509
What changes
ir.model.access.csv->ir.access.csv(upgrade_code19.4-00-ir-access; the other upgrade_code scripts changed nothing).type_companyfilter is gone frombase.view_res_partner_filterin 20(19.0
odoo/addons/base/views/res_partner_views.xml:328). The state filters now go afterfilter_vat_set(20.0, same file:331), in the same group.es.poexported again with
--force-sync.depends,auto_installand license unchanged.ir.model.fieldsfor internal users is now limited tores.partnerfields(before, the whole table; in 20 that includes fields such as
ai_fieldsprompt_custom).Notes
mail.thread._track_get_fieldsmoved tomail.track.mixinin 20; the override onres.partnerstill applies (checked in a 20 shell).mail_tracking,the tracking is only in the message body, so the new test reads the field labels from there.
portal_partner_stategoes in its own PR.res.partnerfield removed in 20 are deleted incascade during the upgrade. A script in
ingadhoc/odoo-upgrade(same branch) reports them.Tests
previous
_track_get_fieldsand passes with the fix.