Repository navigation
Conversation
- ir.attachment has no datas field in 20.0: chunks and the final file are written and read with raw (bytes in, raw.content out). - ir.config_parameter.get_param was removed: the threshold uses get_int, with 500 as default as before. - web CSVExport.from_data returns bytes in 20.0, so the .encode() call broke every CSV export in background. - The export dialog in 20.0 can export translatable fields in several languages (getFieldsToExport). The background branch now sends the same fields the standard button sends.
Contributor
|
|
les-adhoc
marked this pull request as ready for review
November 12, 2026 13:11
Contributor
|
@roboadhoc r+ nobump rebase-ff |
Contributor
|
Merge method set to rebase and fast-forward. |
Contributor
Author
|
@roboadhoc check |
Contributor
|
Updated message. No update to pr head. |
Contributor
Author
|
@roboadhoc retry |
Contributor
|
@les-adhoc retry makes no sense when the PR is not in error. |
les-adhoc
force-pushed
the
20.0-t-76642-les
branch
from
November 12, 2026 17:06
16e9e82 to
d54be46
Compare
Contributor
|
@roboadhoc r+ nobump rebase-ff |
Contributor
|
Merge method set to rebase and fast-forward. |
roboadhoc
pushed a commit
that referenced
this pull request
Nov 12, 2026
Part-of: #512 Signed-off-by: Matias Velazquez <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Nov 12, 2026
Part-of: #512 Signed-off-by: Matias Velazquez <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Nov 12, 2026
- ir.attachment has no datas field in 20.0: chunks and the final file are written and read with raw (bytes in, raw.content out). - ir.config_parameter.get_param was removed: the threshold uses get_int, with 500 as default as before. - web CSVExport.from_data returns bytes in 20.0, so the .encode() call broke every CSV export in background. - The export dialog in 20.0 can export translatable fields in several languages (getFieldsToExport). The background branch now sends the same fields the standard button sends. Part-of: #512 Signed-off-by: Matias Velazquez <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Nov 12, 2026
Part-of: #512 Signed-off-by: Matias Velazquez <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Nov 12, 2026
Part-of: #512 Signed-off-by: Matias Velazquez <[email protected]>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tarea: https://www.adhoc.inc/odoo/project.task/76642
Migrates
export_bgfrom 19.0 to 20.0. Depends onbase_bg, already merged in 20.0.Changes
ir.attachment.datasdoes not exist in 20.0: chunks and the final file are written withrawand read withraw.content.ir.config_parameter.get_paramwas removed: the threshold usesget_int("export_bg.record_threshold", 500)(same default as before).CSVExport.from_datareturns bytes in 20.0 (odoo/odoo@e3c7ff62d7fa,web/controllers/export.py), so the.encode()call broke every CSV export in background. Removed.getFieldsToExport(), the same fields the standard button sends.upgrade_code19.5-00-material-symbols-icons: the download icon of the chat message uses Material Symbols.es.poexported and translated for 20.0.depends,auto_installor license. No data migration script needed: the module has no stored fields or models of its own.Tests
The module had no tests in 19.0. Added 4 tests for 20.0 (
tests/test_export_bg.py):bg.jobis only visible to its creator).Local 20.0 database: the module installs and the 4 tests pass. Also checked in the browser: under the threshold the file downloads at once; over it, the export goes to background and the chat message brings the download link to a single CSV with all the records.
Not changed (pre-existing in 19.0)
root.countis the number of groups, so the background export rarely triggers there.write_rowand can be truncated without warning over the row limit.order="name"sortschunk_10beforechunk_2.