Skip to content

[MIG] base_company_dependent: Migration to 20.0 - #464

Closed
rov-adhoc wants to merge 2 commits into
ingadhoc:20.0from
adhoc-dev:20.0-t-76423-rov
Closed

rov-adhoc wants to merge 2 commits into
ingadhoc:20.0from
adhoc-dev:20.0-t-76423-rov

Conversation

@rov-adhoc

@rov-adhoc rov-adhoc commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Migration of base_company_dependent from 19.0 to 20.0.

Tarea: https://www.adhoc.inc/odoo/project.task/76423

Changes

  • Bump version to 20.0.1.0.0 and set installable to True.
  • ir.model.access no longer exists in 20.0 (replaced by ir.access): model-level checks now use env[model].browse().check_access(op).
  • Owl 3:
    • owl3-migration from upgrade_code applied (proxy, usePlugin(NotificationPlugin), this. in templates, t-out).
    • static props replaced by props = useProps(...) in CompanyDependentButton and CompanyDependentDialog.
    • The field templates this module replaces (Char, Integer, Float, Monetary, Selection, Boolean, Many2One, DateTime) are synced with the 20.0 web templates. Refs now point to the signal.ref() of each field (this.input, this.numpadDecimalRef, this.rootRef). The t-custom-ref produced by upgrade_code is not a directive in 20.0.
  • Font Awesome icons replaced by Material Symbols (oi + data-icon).
  • Field subclasses loaded before fields_patch.js (for example Many2OneBankField) keep a copy of components without the button but inherit the patched template. addButtonToFieldSubclasses() adds the button to them.
  • Tests: the test model ACL moves to ir.access with base.group_user (a group-less ir.access is a restriction in 20.0).
  • README and translations updated for 20.0.
  • New Hoot tests (static/tests/base_company_dependent.test.js): the button on the 8 field types, default and specific values, saving a Char field, boolean_toggle in form and list (one button per row), the dialog (save, copy to child companies, reset, skipped companies) and the field subclass fix.

No data migration script is needed: the module has no stored fields of its own (both models are abstract) and no data files.

Test plan

  • Install base_company_dependent on a new 20.0 database with demo data.
  • Run the module tests: 40 tests, 0 failures.
  • UI: add a company dependent Char field (res.partner.barcode) to a form view. Check that the company button shows, that a typed value is saved, and that the per-company dialog opens.
  • Not tested in the UI: the other field types, and saving from the dialog. The new Hoot tests cover them; they were not run locally (no Chrome), runbot runs them.
  • Not tested on an upgraded database: there is no 19.0 → 20.0 upgrade pipeline yet.

@roboadhoc

Copy link
Copy Markdown
Contributor

Pull request status dashboard

@rov-adhoc rov-adhoc changed the title [WIP] [MIG] base_company_dependent: Migration to 20.0 [MIG] base_company_dependent: Migration to 20.0 Oct 8, 2026
@rov-adhoc
rov-adhoc force-pushed the 20.0-t-76423-rov branch 2 times, most recently from e6bfb0c to 3ca2c95 Compare October 9, 2026 11:12
@rov-adhoc
rov-adhoc force-pushed the 20.0-t-76423-rov branch 2 times, most recently from 63846dc to 0f3f6b3 Compare October 19, 2026 17:57
@matiasperalta1

Copy link
Copy Markdown
Contributor

@roboadhoc r+ nobump rebase-ff

@roboadhoc

Copy link
Copy Markdown
Contributor

Merge method set to rebase and fast-forward.

roboadhoc pushed a commit that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
Updated by "Update PO files to match POT (msgmerge)" add-on in Weblate.

Translation: multi-company-19.0/multi-company-19.0-account_multicompany_ux
Translate-URL: https://translation.dev-adhoc.com/projects/multi-company-19-0/multi-company-19-0-account_multicompany_ux/
(cherry picked from commit d8669cb)

Part-of: #328
Related: ingadhoc/miscellaneous#464
Signed-off-by: matiasperalta1 <[email protected]>
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
Updated by "Update PO files to match POT (msgmerge)" add-on in Weblate.

Translation: multi-company-19.0/multi-company-19.0-account_multicompany_ux
Translate-URL: https://translation.dev-adhoc.com/projects/multi-company-19-0/multi-company-19-0-account_multicompany_ux/
(cherry picked from commit d8669cb)

Part-of: #328
Related: ingadhoc/miscellaneous#464
Signed-off-by: matiasperalta1 <[email protected]>
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
Updated by "Update PO files to match POT (msgmerge)" add-on in Weblate.

Translation: multi-company-19.0/multi-company-19.0-account_multicompany_ux
Translate-URL: https://translation.dev-adhoc.com/projects/multi-company-19-0/multi-company-19-0-account_multicompany_ux/
(cherry picked from commit d8669cb)

Part-of: #328
Related: ingadhoc/miscellaneous#464
Signed-off-by: matiasperalta1 <[email protected]>
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
@roboadhoc

Copy link
Copy Markdown
Contributor

@rov-adhoc @matiasperalta1 staging failed: ci/runbot-oba on a424983831c72616d89c35541a002f671d004f93 (view more at https://runbot.dev-adhoc.com/runbot/batch/124165/build/181751)

@lef-adhoc

Copy link
Copy Markdown
Contributor

@roboadhoc r+ nobump rebase-ff

@roboadhoc

Copy link
Copy Markdown
Contributor

Merge method set to rebase and fast-forward.

roboadhoc pushed a commit that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
Updated by "Update PO files to match POT (msgmerge)" add-on in Weblate.

Translation: multi-company-19.0/multi-company-19.0-account_multicompany_ux
Translate-URL: https://translation.dev-adhoc.com/projects/multi-company-19-0/multi-company-19-0-account_multicompany_ux/
(cherry picked from commit d8669cb)

Part-of: #328
Related: ingadhoc/miscellaneous#464
Signed-off-by: Franco Leyes <[email protected]>
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
In 20.0 _reconcile_reversed_moves no longer exists: _post reconciles
the reversed moves inline through _reconcile_plan, so the override was
dead code and the credit note moved to another company paid the origin
invoice again.

Filter the cross-company reversal groups out of the reconciliation plan
while posting instead.

Part-of: #328
Related: ingadhoc/miscellaneous#464
Signed-off-by: Franco Leyes <[email protected]>
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
…d downpayment account to 20.0

- Journal display name: keep the native name when show_company_journal is in
  the context (20.0 prefixes the company there), and call super only once
  for the journals without suffix instead of on the whole recordset inside
  the loop.
- Skip the sale order line access check on move line deletion while any
  module is being uninstalled: in 20.0 at_uninstall=False only skips it for
  this module, and uninstalls run with the user env.
- Drop the downpayment key lookup: get_product_accounts never returns it.

Part-of: #328
Related: ingadhoc/miscellaneous#464
Signed-off-by: Franco Leyes <[email protected]>
roboadhoc pushed a commit to ingadhoc/multi-company that referenced this pull request Nov 12, 2026
Per ADR 0050 the migrations/ folders are not kept on the 20.0 branch.

closes #328

Related: ingadhoc/miscellaneous#464
Signed-off-by: Franco Leyes <[email protected]>
@roboadhoc roboadhoc added the 19.1 label Nov 12, 2026
@roboadhoc roboadhoc closed this in 07b5e78 Nov 12, 2026
@roboadhoc
roboadhoc deleted the 20.0-t-76423-rov branch November 12, 2026 20:43

This branch was previously deployed

1 inactive deployment
merge — 84b590cd Deployed Nov 12, 2026 by roboadhoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants