Repository navigation
Conversation
(cherry picked from commit 811db64)
The override needed no change: in 20.0 calendar.event._microsoft_values keeps the signature (microsoft_calendar/models/calendar_event.py:538), the Graph payload still carries the attendees key, and hr_holidays still creates the leave event with no_mail_to_attendees=True (hr_holidays/models/hr_leave.py:2064). Regenerate i18n and translate the module name and summary.
…attendees The module shipped without tests: ingadhoc#64 added one and dropped it before merging. This covers both call shapes 20.0 uses for _microsoft_values -microsoft_sync passes fields_to_sync only, calendar.recurrence adds initial_values- and fails if the attendees key survives in the payload.
Contributor
|
|
Contributor
|
@roboadhoc r+ nobump rebase-ff |
Contributor
|
Merge method set to rebase and fast-forward. |
roboadhoc
pushed a commit
that referenced
this pull request
Nov 12, 2026
(cherry picked from commit 811db64) Part-of: #79 Signed-off-by: Juan Carreras <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Nov 12, 2026
The override needed no change: in 20.0 calendar.event._microsoft_values keeps the signature (microsoft_calendar/models/calendar_event.py:538), the Graph payload still carries the attendees key, and hr_holidays still creates the leave event with no_mail_to_attendees=True (hr_holidays/models/hr_leave.py:2064). Regenerate i18n and translate the module name and summary. Part-of: #79 Signed-off-by: Juan Carreras <[email protected]>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calendar.event._microsoft_valueskeeps its signature in 20.0 (microsoft_calendar/models/calendar_event.py:538; the file was renamed, the method was not), the Graph payload still builds theattendeeskey, andhr_holidaysstill creates the leave event withno_mail_to_attendees=True(hr_holidays/models/hr_leave.py:2064), so the override migrates unchanged._microsoft_values—microsoft_syncpassesfields_to_synconly,calendar.recurrenceaddsinitial_values— and fail if theattendeeskey survives in the payload.dependsandauto_installunchanged. No data migration script is needed: the module declares no fields, models or data.Checks: migrator and
upgrade_code(no changes), static checks, imports, permissions, pre-commit. Installed on a clean 20.0 database — it installs on its own,auto_installwithhr_holidaysandmicrosoft_calendar— and its 2 tests pass.Heads-up for review, not introduced here: in 20.0 this module no longer changes anything in the time off flow. A leave event for an employee without an Odoo user has no
calendar_id, and 20.0 requires one both for the immediate insert (microsoft_calendar/models/microsoft_sync.py:110-114) and in the cron domain (microsoft_calendar/models/calendar_event.py:320-321, new in 20.0), so it never reaches Outlook — and that was the case this module was written for. For an employee with an Odoo user the only attendeehr_holidaysadds is the organizer, which the core already filters out (calendar_event.py:571). Whether to adopt the 20.0 behaviour or extend the module is a product decision pending in the internal task; the override is untouched here.Tarea: https://www.adhoc.inc/odoo/project.task/76816