Repository navigation
Conversation
The test attachment was named cv.pdf but its content is b"cv", not a PDF. With Documents installed, documents_hr_recruitment turns the applicant attachments into documents and counts the pages of every PDF, so pypdf logged a warning with a traceback and the build failed. The test only checks that the attachment is copied once, so a text file covers the same case.
Contributor
|
|
Contributor
|
Ya lo mezclo les acá #78 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tarea: https://www.adhoc.inc/odoo/project.task/76585
The talent pool test creates an attachment named
cv.pdfwhose content isb"cv", not a PDF. When Documents is installed,documents_hr_recruitment(auto_install withdocuments_hr+hr_recruitment) turns applicant attachments into documents and counts the pages of every PDF: pypdf logs a warning with a traceback (Impossible to count pages in 'cv.pdf') and the build fails.The test only checks that the attachment is copied once to the talent, so a text attachment covers the same case.
Goes with ingadhoc/enterprise-extensions#1158 (same branch), which makes
documents_account_bginstallable in 20.0 and so brings Documents into the build.