Repository navigation
Conversation
(cherry picked from commit 1dd74a8)
- google.calendar.sync is split into google.sync and google.event.sync: _google_insert takes the target calendar as a new argument, so the override follows the 20.0 signature. - TIMEOUT is no longer exported by google_calendar.models.google_sync: import it from google_account.models.google_service. - Regenerate i18n and translate the module name and summary.
Contributor
|
|
mav-adhoc
changed the title
…apes Odoo 20 calls _google_insert with two signatures: google_event_sync.py:68 still omits `calendar`, while lines 129 and 174 pass it. Upstream wraps the method in @after_commit, which takes any arguments and defers the call, so without this module the mismatch only ends as a post-commit warning. The override ran first and raised TypeError inside the transaction, so confirming a draft event failed. It now forwards whatever it gets. Also add the first test of the module: it covers both call shapes and the send_updates=False suppression, and fails with the previous signature. Change note: en Odoo 20, confirmar un evento de calendario en borrador fallaba con error en las bases que tienen instalado este modulo (se instala solo). Ahora confirma bien, y se mantiene que una ausencia aprobada no le mande la invitacion de Google a los asistentes.
Contributor
|
@roboadhoc r+ nobump rebase-ff |
Contributor
|
Merge method set to rebase and fast-forward. |
roboadhoc
pushed a commit
that referenced
this pull request
Oct 30, 2026
(cherry picked from commit 1dd74a8) Part-of: #74 Signed-off-by: Luciano Esperlazza <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Oct 30, 2026
- google.calendar.sync is split into google.sync and google.event.sync: _google_insert takes the target calendar as a new argument, so the override follows the 20.0 signature. - TIMEOUT is no longer exported by google_calendar.models.google_sync: import it from google_account.models.google_service. - Regenerate i18n and translate the module name and summary. Part-of: #74 Signed-off-by: Luciano Esperlazza <[email protected]>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google.calendar.syncis split intogoogle.syncandgoogle.event.sync:_google_insertnow takes the target calendar, so the override follows the new signature.TIMEOUTis no longer exported bygoogle_calendar.models.google_sync; it comes fromgoogle_account.models.google_service, which is where 19.0 took it from as well (same value).dependsandauto_installunchanged. No data migration script is needed: the module declares no fields, models or data.Checks: migrator and
upgrade_code(no changes), static checks, imports, permissions, pre-commit. Installed and updated on a clean 20.0 database; the module ships no tests.Heads-up for review, not introduced here: in odoo/odoo 20.0
GoogleEventSync.writecalls_google_insertwithout the newcalendarargument (google_calendar/models/google_event_sync.py:68), so that path raises aTypeErrorupstream. The create path used byhr_holidayspasses all three arguments.Tarea: https://www.adhoc.inc/odoo/project.task/76665