Repository navigation
feat: support Swagger 2.0 sources - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swagger: "2.x", JSON or YAML) are now converted to OpenAPI 3.0.3 before merging instead of being rejected. Swagger 1.x is still rejected with a clear error.swagger2module inopenapi-aggregator-core(no new dependencies, still wasm-compatible), so the CLI, the library and the playground behave identically.source 'legacy': collectionFormat 'tsv' is not supported in OpenAPI 3; dropped.additional_blocksare applied after conversion, so they are written in 3.x shape.prepare_source_with_notes/PreparedSourceAPI;prepare_sourcekeeps its signature.What is converted
host/basePath/schemestoservers;definitions/parameters/responsestocomponentswith$refrewriting (includingdiscriminator.mapping);consumes/producesto media types (operation overrides root);in: bodyandin: formDatatorequestBody(multipart when files are involved); non-body parameters toschema, withcollectionFormatmapped tostyle/explode; responseschema,headersandexamples;securityDefinitionsincluding OAuth2 flows;type: file,x-nullableand stringdiscriminator.Test plan
cargo test --workspace(unit tests per conversion rule, Swagger Petstore 2.0 fixture, 2.0 + 3.x merge withrenamewhere every$refresolves, wasm warning test)cargo clippy --workspace --all-targets -- -D warningsandcargo fmt --checkcd web && npm testandnpm run e2e