Repository navigation
feat(themes):make style menu opt-in and add phone display panel - #61
Merged
Merged
Conversation
- theme.style_picker (default false) controls the Style menu - Version, Style and Mode sit behind a Display button on screens <=768px - Version menu only appears when a site has more than one release - panel closes on outside tap or Escape; long brand names truncate - fix empty desktop menu column; 16px phone search text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the reader-facing header, following the last UI/UX review.
theme.style_picker(defaultfalse). When it is off, visitors see the configuredtheme.style, and a style they saved earlier is ignored. The DocSprout site and the visual fixtures opt in./hint hidden on touch screens.Reviewer notes:
"style_picker": true. This is noted inCHANGELOG.mdanddocs/themes.md.Checklist
python -m unittest discover -s tests -t . -v(ran with pytest: 357 passed)docsprout checkanddocsprout audit --strictCHANGELOG.md,docs/versions.jsonand workflow pins updated together (not a release)