Skip to content

feat(themes):make style menu opt-in and add phone display panel - #61

Merged
ikelaiah merged 1 commit into
mainfrom
dev/header-display-panel
Nov 8, 2026
Merged

ikelaiah merged 1 commit into
mainfrom
dev/header-display-panel

Conversation

@ikelaiah

@ikelaiah ikelaiah commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Simplifies the reader-facing header, following the last UI/UX review.

  • Style menu is opt-in. New theme.style_picker (default false). When it is off, visitors see the configured theme.style, and a style they saved earlier is ignored. The DocSprout site and the visual fixtures opt in.
  • Phone Display panel. At 768px and below, Version, Style and Mode move behind a Display button next to search. Before the title, the header goes from about 270px to about 170px. The panel closes on a tap outside it or on Escape (Escape inside search still closes the search results). Long project names end in an ellipsis.
  • Version menu only for several releases. Single-release sites no longer show a one-option menu.
  • Fixes: no empty desktop menu column when a menu is hidden; phone search uses 16px text (no iOS zoom on focus); / hint hidden on touch screens.

Reviewer notes:

  • Behaviour change: sites that relied on visitors switching Style must add "style_picker": true. This is noted in CHANGELOG.md and docs/themes.md.
  • In the page code the Display button comes after search, so Tab order matches the phone layout. Tested in the browser at 320, 375, 768 and 1280px, light and dark.

Checklist

  • Tests pass: python -m unittest discover -s tests -t . -v (ran with pytest: 357 passed)
  • Documentation checks pass: docsprout check and docsprout audit --strict
  • Guides, examples or migration notes updated when behaviour changes
  • For a release: version metadata, CHANGELOG.md, docs/versions.json and workflow pins updated together (not a release)
  • No secrets, tokens or credentials added

- theme.style_picker (default false) controls the Style menu
- Version, Style and Mode sit behind a Display button on screens <=768px
- Version menu only appears when a site has more than one release
- panel closes on outside tap or Escape; long brand names truncate
- fix empty desktop menu column; 16px phone search text
@ikelaiah ikelaiah self-assigned this Nov 8, 2026
@ikelaiah
ikelaiah merged commit 2a89e43 into main Nov 8, 2026
75 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant