Repository navigation
Release DocSprout v1.5.0: theme quality - #60
Merged
Merged
Conversation
- Callout labels meet WCAG AA in every style and colour mode. - The search placeholder uses the muted text colour. - Focus rings are no longer clipped in the sidebar and outline, and use the code text colour on code blocks. - E-ink is ink-only: links, focus, buttons, navigation, icons and syntax use the text colour. Callouts differ by rule and marker shape. - Top-level phone menu pages use the text colour, not default link blue. - The reading measure is set in ch, keeping 58-73 characters per line. - Code blocks follow the style: printed warm code in Paper, frosted panels in Glassmorphic, window dots in Classic only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theme-quality minor release. It fixes the three P1 issues and the contrast failures from a design critique of all four styles (Classic, Paper, E-ink, Glassmorphic) in Light and Dark.
Contrast (all styles and modes)
--dk-callout-*tokens.--dk-muted. The browser default had failed in all 8 combinations.--dk-code-text; Paper Light's copy-button ring goes from 2.65:1 to 11.7:1.E-ink is ink-only
bodyrule maps the accent, link, focus and button tokens to the text colour. The palette generator no longer emits E-ink entries.Reading measure and code
--dk-reading-widthis set inch: compact 54, comfortable 60 and wide 64, with narrower Paper values because Georgia's digits are narrow. Measured plain prose is 58–73 characters per line in every style and width. It was up to about 99 before.Also fixed: top-level pages in the phone menu were browser-default blue in every style.
Release prep: version 1.5.0,
v1.5.0pins,docs/versions.json, the changelog, the migration guide (v1.4.1 to v1.5.0, noting the three visible changes), the qualification page and the roadmap.Checklist
python -m unittest discover -s tests -t .(355 tests, run withPYTHONPATH=src)docsprout checkanddocsprout audit --strict(0 errors, 0 warnings)CHANGELOG.md,docs/versions.jsonand workflow pins updated togetherThe wheel and sdist each passed
qualification_installed.py --expected-version 1.5.0in a fresh virtual environment.doctorreports only the expected missingv1.5.0tag. After merge: create the annotated tagv1.5.0on the merge commit, runcheck-releaseandbuild-all, push the tag, then publish the GitHub Release.