Repository navigation
test: stabilize Windows read-budget isolation checks - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix intermittent Windows failures in the task read-budget regression. Session discovery sorts by modification time; tied timestamps can put the requested task first, so the resolver legitimately returns before probing unrelated metadata. The old test assumed the unrelated file was always visited.
Exercise both discovery orders explicitly: unrelated-first must probe with the default byte limit, while selected-first must return without reading unrelated metadata. Keep the budget assertions strict and remove dependence on filesystem timestamp resolution.
Privacy impact
Test-only change. Runtime session discovery, byte budgets, returned task data, redaction, and consent behavior are unchanged.
Validation
uv run ruff format --check .uv run ruff check .uv run mypyValidate all GitHub CI jobs before merging and verify the subsequent main-branch push run as well.