Skip to content

CC-124: <PdfViewer/> State Not Reset on File Change #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianpaschal merged 1 commit into from
Aug 26, 2026
Merged

CC-124: <PdfViewer/> State Not Reset on File Change #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/components/PdfViewer/PdfViewer.hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export const DEFAULT_CONFIG: PdfViewerConfig = {
};

export const usePdfViewer = (
file: string | File | ArrayBuffer | null,
customConfig?: Partial<PdfViewerConfig>,
): UsePdfViewerReturn => {
const config = {
Expand All @@ -39,13 +40,22 @@ export const usePdfViewer = (
};
const containerRef = useRef<HTMLDivElement>(null);
const ref = useRef<HTMLDivElement>(null);
const [prevFile, setPrevFile] = useState(file);
const [numPages, setNumPages] = useState<number | null>(null);
const [pageNumber, setPageNumber] = useState(config.initialPage);
const [scale, setScale] = useState(config.initialScale ?? 1);
const pdfPageWidthRef = useRef<number | null>(null);
const isScrollingTo = useRef(false);
const scrollTimeoutRef = useRef<ReturnType<typeof setTimeout>>();

if (file !== prevFile) {
setPrevFile(file);
setNumPages(null);
setPageNumber(config.initialPage);
setScale(config.initialScale ?? 1);
pdfPageWidthRef.current = null;
}

useEffect(() => () => clearTimeout(scrollTimeoutRef.current), []);

const scrollToPage = useCallback((page: number) => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/PdfViewer/PdfViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const PdfViewer = ({
if (workerSrc && pdfjs.GlobalWorkerOptions.workerSrc !== workerSrc) {
pdfjs.GlobalWorkerOptions.workerSrc = workerSrc;
}
const viewer = usePdfViewer(restConfig);
const viewer = usePdfViewer(file, restConfig);
return (
<div ref={viewer.containerRef} className={clsx(styles.pdfViewer, className)}>
{(loading || viewer.state.numPages === null) && (
Expand Down
Loading