Repository navigation
Fix Spacebar Take priority over focused controls (#668) - #1206
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #668 and the manual-first RC controls in #1205.
Spacebar now defaults to Take in Studio. A parent keyboard accelerator was being consumed by the focused transition selector, opening its Cut/Fade menu instead. Handle Space in PreviewKeyDown/PreviewKeyUp before button activation, consume it even when Take is unavailable, ignore auto-repeat, and preserve normal typing and modified keys. Ctrl+Enter remains an alternate; FTB and remote controls are unchanged.
Validation: Windows Release build passed and the corrected app was launched locally with the GPU renderer and Zoom runtime ready. Full Windows UI tests and hosted CI are being run for beta inclusion. Physical keyboard behavior still needs operator confirmation; no desktop input was injected.