Repository navigation
Sources table-first review with optional inspector - #275
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related owner review: iamfatness/CoreVideoPro#590
The owner prefers the current table's information density but wants friendlier detailed editing. Publish an alternative /reviews/sources-table/ mockup that defaults to the table, opens/closes an inspector on the same populated inputs, and keeps the existing Assign / Route / Compose workflow. Preserve earlier proposals for comparison.
Show observed format/FPS, source category, signal, audio summary, quick MV and ISO arm/writer distinction. Add saved secondary column choices and narrow row Details, retaining core columns without horizontal page scrolling. The inspector demonstrates explicit assignment, source-bound lower-third drafts and synchronized opacity controls. Adapter dialogs and real audio/production processing are explicitly outside the mockup.
Feedback has its own review key and is included in encrypted maintainer export. No installed app, settings, webcam ownership or native code changes.
Validation: eight feedback contract tests, static build/SEO, and headless Chromium checks of ten slots, overview/inspector selection and state, quick MV/ISO, disconnect/reconnect identity, exact controls, saved columns, row Details, feedback receipt, and both layouts at 1600/1280/900/600/390 widths. Inspected desktop and phone screenshots.