Total temperature boundary cannot be set in the Tt file when using hy2foam

[Rockyuo666]

Total temperature boundary cannot be set in the Tt file when using hy2foam,but can be set in Tv file.Why it happens?

[timeExplore]

I am using hyStrath code in OpenFOAM-v1706. You can see the following code of fixed2EnergyFvPatchScalarField::updateCoeffs() in src/thermophysicalModels/strath/strathReactionThermo/reactionThermo/derivedFvPatchFields/fixedEnergy/fixed2EnergyFvPatchScalarField.C
` if (updated())
{
return;
}

//Info<< "fixed2Energy is used for patch called "
//    << patch().name() << endl;

const multi2Thermo& multiThermo = multi2Thermo::lookup2Thermo(*this);

const label patchi = patch().index();

const fvPatchScalarField& pw = multiThermo.p().boundaryField()[patchi];
const fvPatchScalarField& Tw = multiThermo.T().boundaryField()[patchi];

tmp<scalarField> thet(new scalarField(pw.size()));
tmp<scalarField> thevel(new scalarField(pw.size()));

scalarField& het = thet.ref();
scalarField& hevel = thevel.ref();

het = 0.0;
hevel = 0.0;

forAll(thermo_.composition().species(), speciei)
{
    const fvPatchScalarField& spYw =
        thermo_.composition().Y(speciei).boundaryField()[patchi];
    const fvPatchScalarField& spTvw =
        thermo_.composition().Tv(speciei).boundaryField()[patchi];

    het += spYw*thermo_.composition().het(speciei, pw, Tw, patchi);
    hevel += spYw*thermo_.composition().hevel(speciei, pw, spTvw, patchi);
}

operator==(het + thevel);

fixedValueFvPatchScalarField::updateCoeffs();`

Compared with the similar code in the original OpenFOAM-v1706 code, there seems to be no code like "Tw.evaluate();", I think this is the reason.

[LDK29]

I am using hyStrath code in OpenFOAM-v1706. You can see the following code of fixed2EnergyFvPatchScalarField::updateCoeffs() in src/thermophysicalModels/strath/strathReactionThermo/reactionThermo/derivedFvPatchFields/fixedEnergy/fixed2EnergyFvPatchScalarField.C ` if (updated()) { return; }

//Info<< "fixed2Energy is used for patch called "
//    << patch().name() << endl;

const multi2Thermo& multiThermo = multi2Thermo::lookup2Thermo(*this);

const label patchi = patch().index();

const fvPatchScalarField& pw = multiThermo.p().boundaryField()[patchi];
const fvPatchScalarField& Tw = multiThermo.T().boundaryField()[patchi];

tmp<scalarField> thet(new scalarField(pw.size()));
tmp<scalarField> thevel(new scalarField(pw.size()));

scalarField& het = thet.ref();
scalarField& hevel = thevel.ref();

het = 0.0;
hevel = 0.0;

forAll(thermo_.composition().species(), speciei)
{
    const fvPatchScalarField& spYw =
        thermo_.composition().Y(speciei).boundaryField()[patchi];
    const fvPatchScalarField& spTvw =
        thermo_.composition().Tv(speciei).boundaryField()[patchi];

    het += spYw*thermo_.composition().het(speciei, pw, Tw, patchi);
    hevel += spYw*thermo_.composition().hevel(speciei, pw, spTvw, patchi);
}

operator==(het + thevel);

fixedValueFvPatchScalarField::updateCoeffs();`

Compared with the similar code in the original OpenFOAM-v1706 code, there seems to be no code like "Tw.evaluate();", I think this is the reason.

So，could you please give some advice to fix this issue?

[timeExplore]

Sure, I will share my idea. In Foam::fixed2EnergyFvPatchScalarField::updateCoeffs() function from src/thermophysicalModels/strath/strathReactionThermo/reactionThermo/derivedFvPatchFields/fixedEnergy/fixed2EnergyFvPatchScalarField.C, I have made following changes.
First, I comment original code at line 113:

    const fvPatchScalarField& Tw = multiThermo.T().boundaryField()[patchi]; 

Then add two lines behind the commented line:

    fvPatchScalarField& Tw = const_cast<fvPatchScalarField&>(multiThermo.T().boundaryField()[patchi]);
    Tw.evaluate();

The modified version will look like:

void Foam::fixed2EnergyFvPatchScalarField::updateCoeffs()
{
    if (updated())
    {
        return;
    }

    //Info<< "fixed2Energy is used for patch called "
    //    << patch().name() << endl;

    const multi2Thermo& multiThermo = multi2Thermo::lookup2Thermo(*this);

    const label patchi = patch().index();

    const fvPatchScalarField& pw = multiThermo.p().boundaryField()[patchi];
    //const fvPatchScalarField& Tw = multiThermo.T().boundaryField()[patchi];
    
    fvPatchScalarField& Tw = const_cast<fvPatchScalarField&>(multiThermo.T().boundaryField()[patchi]);
    Tw.evaluate();

    tmp<scalarField> thet(new scalarField(pw.size()));
    tmp<scalarField> thevel(new scalarField(pw.size()));
    
    scalarField& het = thet.ref();
    scalarField& hevel = thevel.ref();

    het = 0.0;
    hevel = 0.0;
    
    forAll(thermo_.composition().species(), speciei)
    {
        const fvPatchScalarField& spYw =
            thermo_.composition().Y(speciei).boundaryField()[patchi];
        const fvPatchScalarField& spTvw =
            thermo_.composition().Tv(speciei).boundaryField()[patchi];

        het += spYw*thermo_.composition().het(speciei, pw, Tw, patchi);
        hevel += spYw*thermo_.composition().hevel(speciei, pw, spTvw, patchi);
    }

    operator==(het + thevel);

    fixedValueFvPatchScalarField::updateCoeffs();
}

I think this can fix the issue.

[LDK29]

Sure, I will share my idea. In Foam::fixed2EnergyFvPatchScalarField::updateCoeffs() function from src/thermophysicalModels/strath/strathReactionThermo/reactionThermo/derivedFvPatchFields/fixedEnergy/fixed2EnergyFvPatchScalarField.C, I have made following changes. First, I comment original code at line 113:

    const fvPatchScalarField& Tw = multiThermo.T().boundaryField()[patchi]; 

Then add two lines behind the commented line:

    fvPatchScalarField& Tw = const_cast<fvPatchScalarField&>(multiThermo.T().boundaryField()[patchi]);
    Tw.evaluate();

The modified version will look like:

void Foam::fixed2EnergyFvPatchScalarField::updateCoeffs()
{
    if (updated())
    {
        return;
    }

    //Info<< "fixed2Energy is used for patch called "
    //    << patch().name() << endl;

    const multi2Thermo& multiThermo = multi2Thermo::lookup2Thermo(*this);

    const label patchi = patch().index();

    const fvPatchScalarField& pw = multiThermo.p().boundaryField()[patchi];
    //const fvPatchScalarField& Tw = multiThermo.T().boundaryField()[patchi];
    
    fvPatchScalarField& Tw = const_cast<fvPatchScalarField&>(multiThermo.T().boundaryField()[patchi]);
    Tw.evaluate();

    tmp<scalarField> thet(new scalarField(pw.size()));
    tmp<scalarField> thevel(new scalarField(pw.size()));
    
    scalarField& het = thet.ref();
    scalarField& hevel = thevel.ref();

    het = 0.0;
    hevel = 0.0;
    
    forAll(thermo_.composition().species(), speciei)
    {
        const fvPatchScalarField& spYw =
            thermo_.composition().Y(speciei).boundaryField()[patchi];
        const fvPatchScalarField& spTvw =
            thermo_.composition().Tv(speciei).boundaryField()[patchi];

        het += spYw*thermo_.composition().het(speciei, pw, Tw, patchi);
        hevel += spYw*thermo_.composition().hevel(speciei, pw, spTvw, patchi);
    }

    operator==(het + thevel);

    fixedValueFvPatchScalarField::updateCoeffs();
}

I think this can fix the issue.

Many thanks for your code! I will try it later.

[LDK29]

This issue have been fixed by following the code of @timeExplore