chore: migrate to pnpm workspaces - #181
Merged
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces yarn 1 +
symlink-workspacewith pnpm workspaces, matching the setup used in the other monorepos (pnpm-workspace.yaml,pnpm -rscripts, lerna withnpmClient: pnpm).Root:
workspacesfield →pnpm-workspace.yaml;packageManager: [email protected];yarn.lock→pnpm-lock.yamlpnpm -r run <task>(plusdeps: pnpm up -r -i -L); droppedsymlink-workspaceand thepostinstall: yarn symlinkhook (pnpm links workspace packages itself)^6→^8.2.4withnpmClient: "pnpm"/npmClientArgs: ["--frozen-lockfile"]Packages:
workspace:*(@cosmwasm/ts-codegen-ast,@cosmwasm/ts-codegen-types)prepare: npm run build→prepublishOnly(pnpm runsprepareon every install, which caused a build during install)&&instead of;so a failingtscfails the build@babel/parser+@types/{babel__generator,babel__traverse,minimist}ints-codegen,@babel/generator/@types/babel__generator/globinast,@eslint/js+@eslint/eslintrcat the root (the flat eslint config imports them)packages/ast/test-utils/utils.tsimportedRenderOptionsfrom the built@cosmwasm/ts-codegen-ast/typespath; now imports from../src/typesCI (
lint.yml,autofix.yml,run-tests.yaml):pnpm/action-setup@v4,cache: 'pnpm',pnpm install --frozen-lockfile, and per-package tests viapnpm --filter <pkg> testinstead ofcd <dir> && yarn test.Docs/README development commands updated to
pnpm install/pnpm build/pnpm test:*.Source formatting churn in
context.ts,imports.ts,bundler.ts,plugin-base.ts,types.tsispnpm formatoutput under prettier 3.9 (the old lockfile pinned 3.6) — autofix would produce it on the next run anyway.Verified with a clean
pnpm install --frozen-lockfile: build, 186 tests across both packages, and lint all pass.Link to Devin session: https://app.devin.ai/sessions/bb89d57636c84c7383305191a303b1d4
Open in Devin Desktop: https://app.devin.ai/desktop/session/bb89d57636c84c7383305191a303b1d4?variant=devin
Requested by: @pyramation