ci(hypatia): standardise the wrapper caller id to the canonical hypatia - #58
Merged
Merged
Conversation
…tia` The check a reusable-caller job publishes is `<caller job id> / <inner job display name>`. The estate's canonical required context is `hypatia / Hypatia Neurosymbolic Analysis`, so the caller job must be named `hypatia`. This wrapper named it `scan` and so published `scan / Hypatia Neurosymbolic Analysis` — two names for one gate, and any requirement written against one is unsatisfiable in a repository that publishes the other (the defect class of hyperpolymath/tropical-types#17). Rename only: the job body, its pin, inputs and secrets are byte-for-byte unchanged. Audit-first, requirement-aware sweep — hyperpolymath/standards scripts/propagate-hypatia-caller-id.sh.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (34)
|
| Layer / File(s) | Summary |
|---|---|
Rename the workflow job .github/workflows/hypatia-scan.yml |
The job identifier changes from scan to hypatia. The invoked reusable workflow remains unchanged. |
Priority: ⬇️ Low
Estimated code review effort: 1 (Trivial) | ~2 minutes
Change: Bug fix
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description explains the rename and its purpose, but it does not follow the repository template. It omits the required Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections, a… | Rewrite the description using the repository template. Include Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections. Record the applicable test, formatting, lint, licence, and secrets checks, and state when a section i… |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the CI change and states that the caller job ID is standardised to the canonical hypatia value. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Full details: Description check
Explanation
The description explains the rename and its purpose, but it does not follow the repository template. It omits the required Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections, and it provides no explicit test or quality-check results.
Resolution
Rewrite the description using the repository template. Include Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections. Record the applicable test, formatting, lint, licence, and secrets checks, and state when a section is not applicable.
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the workflow name hypatia now joins the game
The scan still runs as before
No extra steps cross the floor
A tidy change, precise and plain
Comment @coderabbitai help to get the list of available commands.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check a reusable-caller job publishes is
<caller job id> / <inner job display name>. The estate's canonical required context ishypatia / Hypatia Neurosymbolic Analysis(docs/audits/audit-hypatia-pin-orphan-2026-05-27.adoc), so the caller job must be namedhypatia. This wrapper named itscan, and so publishedscan / Hypatia Neurosymbolic Analysis— two names for one gate, and any requirement written against one is unsatisfiable in a repository that publishes the other (the defect class of hyperpolymath/tropical-types#17).Rename only — the job body, its pin, its inputs and its secrets are byte-for-byte unchanged.
Audit-first, requirement-aware: this is
--fixoutput fromscripts/propagate-hypatia-caller-id.shinhyperpolymath/standards(the script stages; it never commits or pushes). The repository's active branch rulesets were read before the rename — no rule here names the old prefixed context, so the published name and every requirement stay in agreement.