Skip to content

ci: vendor validation scripts and remove remote action pins - #52

Merged
hyperpolymath merged 1 commit into
mainfrom
fix-ci-actions
Jul 27, 2026
Merged

ci: vendor validation scripts and remove remote action pins#52
hyperpolymath merged 1 commit into
mainfrom
fix-ci-actions

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Automated PR to fix CI after deleted actions.

Comment thread .githooks/validate-k9.sh
Comment thread .githooks/validate-k9.sh
@gitar-bot

gitar-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 2 resolved / 2 findings

Vendors CI validation scripts and removes remote action pins to fix CI execution after deleted actions. Consider addressing the read loops skipping final lines and normalise_level trimming only a single space.

Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.

✅ 2 resolved
Edge Case: read loops skip final line lacking trailing newline

📄 .githooks/validate-k9.sh:122-131 📄 .githooks/validate-k9.sh:141-150 📄 .githooks/validate-k9.sh:169-183 📄 .githooks/validate-a2ml.sh:102-111 📄 .githooks/validate-a2ml.sh:128-142 📄 .githooks/validate-a2ml.sh:239-253 📄 .githooks/validate-a2ml.sh:270-280
Every content scan in both scripts uses while IFS= read -r line; do ... done < "$file". If a validated file's last line has no trailing newline, read returns non-zero and the loop body never runs for that final line, so its content (e.g. a closing brace, a name/version/signature field) is silently ignored. This can produce spurious validation errors on otherwise-valid files. Use while IFS= read -r line || [[ -n "$line" ]]; do for each scan loop.

Edge Case: normalise_level trims only a single space around leash value

📄 .githooks/validate-k9.sh:95-108
normalise_level uses ${raw## } / ${raw%% }, whose pattern is a single literal space, so it strips at most one leading and one trailing space. A leash value written with extra spacing (e.g. leash = 'Hunt) or a tab leaves residual whitespace in security_level_value, causing the exact-match loop against kennel yard hunt to fail and emit a false "Invalid security level" error. The current single-space example files pass, but the normalization is fragile. Trim all whitespace instead.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@hyperpolymath
hyperpolymath merged commit 9f74842 into main Jul 27, 2026
22 of 25 checks passed
@hyperpolymath
hyperpolymath deleted the fix-ci-actions branch July 27, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant