Skip to content

docs(report-back): the standards lane reads the artifact from d253de27; the campaign is unblocked - #643

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/gitbot-fleet-feedback-0vdo64
Nov 5, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/gitbot-fleet-feedback-0vdo64

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

This follows up hyperpolymath/gitbot-fleet#626. Its rollout docs still said the standards half was prepared but not on main, and that every fixer run would exit 3. The standards half has since merged as d253de27 (metadatastician/standards#1363).

What

  • docs/REPORT-BACK.adoc §5 step 3 now names standards d253de27 as the first commit whose Hypatia lane reads the fleet-report-backs artifact. It also says callers on an older pin must bump it first.
  • docs/REPORT-BACK.adoc §6 says the campaign can run and records the measurement below.
  • ROADMAP.adoc: the rollout line now says the campaign is unblocked.

Evidence

I ran the merged fixer at e44af814 against a scratch repository with STANDARDS_DIR pointing at a standards checkout.

Standards pin in the workflow Fixer exit What it reported
d253de27 (#1363 merged) 0 "wired end to end"
9ae23875 (before #1363) 3 MANUAL: bump the standards pins

Not in this PR

  • The pin bumps that move each consumer to e44af814 are separate PRs:
    • metadatastician/standards fork-governance.yml FLEET_REF
    • hyperpolymath/rsr-template-repo fork-governance.yml FLEET_REF, plus the 85-minute job limit
    • hyperpolymath/metamanifold-webui's reusable pin
  • This repository's own hypatia-scan.yml still pins standards at 75bd5994, which predates the input. Its fleet rows come from the separate dogfood workflow. Moving that pin is the standards pin-propagation PR's job.

Generated by Claude Code

…7; the campaign is unblocked

REPORT-BACK.adoc §5 step 3 still described the standards input as prepared
but not on main, and §6 still said every fixer run would exit 3. Standards#1363
merged as d253de27. Measured 2026-11-04 on a scratch repository: with the
standards pin at d253de27 and FLEET_REF at e44af81 the fixer exits 0; on the
earlier pin 9ae23875 it exits 3 and names the bump. ROADMAP's rollout line
says the same.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01J4QvDjqj5DHRRCrDiGeTmq
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 64ebfbe and 67d9e23.

Files selected for processing: 2
  • ROADMAP.adoc
  • docs/REPORT-BACK.adoc
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 4, 2026 23:50
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T23:53:07.565385Z 67d9e23 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

hyperpolymath commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner Author

Three governance jobs fail on this PR. None of the failures come from this diff, which changes only docs/REPORT-BACK.adoc and ROADMAP.adoc. All three fail the same way on main at the base commit 64ebfbe (run 41294821738).

  • governance / Language / package anti-pattern policy. It finds four Python files that are already on main: scripts/audit-lock-regeneration.py, scripts/audit-workflow-lock-map.py, tests/lock-regeneration-test.py and tests/workflow-lock-map-test.py. The fix is to port them to an allowed language, or for the owner to record an exemption. Either belongs in its own PR.

  • governance / Allowlist Preflight. The four metadatastician/standards/...-reusable.yml@75bd5994 refs in this repository's workflows are not covered by the allowlist at the pinned standards commit. That is the owner-migration gap. The fix is an allowlist entry in standards, or set-allowed-actions.sh, plus the fleet's own standards pin bump. It is not a docs change.

  • governance / Validate Hypatia Baseline. It fails with "16 unfiltered finding(s) at or above 'info'". None of the findings is in a file this PR touches. Among them:

    • RE001 and WH002 in inbox-steward.yml, instant-sync.yml, label-triage.yml, labels.yml, push-email-notify.yml and supervised-fleet-scan.yml;
    • invalid_actions_lock on .github/workflows/actions.lock;
    • banned_language_file on tests/workflow-lock-map-test.py;
    • expect_in_hot_path and unwrap_without_check in bots/*/src.

    The fix is to address those findings, or refresh the baseline, on main.

No fix for any of them exists to port yet. I will re-run the failed jobs once when the run completes.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

build · test · clippy (idris-dependents) is a fourth failure that is not this PR's. This PR touches no Rust. The failing code is the crate's test suite as it stands on main.

  • tests/scan_tests.rs:352: the Mock initialiser in ready_mock() does not set the responses field, which Mock declares, so the test binary does not compile (E0063). Adding responses: BTreeMap::new(), fixes the compile error; I checked this locally on main with cargo test --locked.

  • With that line added, scan_edge_tests still fails two tests:

    • report_json_keeps_public_field_names_and_confidence_spelling: the report now emits a skippedUrls key that the expected JSON does not list.
    • raw_content_fetches_retry_rate_limits_and_propagate_hard_failures: panics at scan_edge_tests.rs:391.

    The code and its tests have drifted. Fixing them needs a decision this PR should not make: is skippedUrls meant to be part of the public report? It belongs to the idris-dependents owner, from hyperpolymath/gitbot-fleet#628 onward, so I am not widening this PR.

No fix exists to port yet.


Generated by Claude Code

@hyperpolymath
hyperpolymath merged commit c24b73f into main Nov 5, 2026
87 of 95 checks passed
@hyperpolymath
hyperpolymath deleted the claude/gitbot-fleet-feedback-0vdo64 branch November 5, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants