Skip to content

fix(pages): pin upload-pages-artifact to v5.0.0 - #74

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/artifact-pin
Oct 3, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/artifact-pin

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

With sha_pinning_required, the older upload-pages-artifact (v3) is rejected at job setup: its internal reference to actions/upload-artifact@v4 is a floating tag, so GitHub refuses with 'all actions must be pinned to a full-length commit SHA' — the job dies before running a single step.

Move to the same revision the working publishers in this estate use: actions/upload-pages-artifact@fc324d3 # v5.0.0.

Summary

Changes

RSR Quality Checklist

Required

  • Tests pass (just test or equivalent)
  • Code is formatted (just fmt or equivalent)
  • Linter is clean (no new warnings or errors)
  • No banned language patterns (no TypeScript, no npm/bun, no Go/Python)
  • No unsafe blocks without // SAFETY: comments
  • No banned functions (believe_me, unsafeCoerce, Obj.magic, Admitted, sorry)
  • SPDX license headers present on all new/modified source files
  • No secrets, credentials, or .env files included

As Applicable

  • .machine_readable/STATE.a2ml updated (if project state changed)
  • .machine_readable/ECOSYSTEM.a2ml updated (if integrations changed)
  • .machine_readable/META.a2ml updated (if architectural decisions changed)
  • Documentation updated for user-facing changes
  • TOPOLOGY.md updated (if architecture changed)
  • CHANGELOG or release notes updated
  • New dependencies reviewed for license compatibility (MPL-2.0 / MPL-2.0)
  • ABI/FFI changes validated (src/abi/ and ffi/zig/ consistent)

Testing

Screenshots

With sha_pinning_required, the older upload-pages-artifact (v3) is rejected at
job setup: its internal reference to actions/upload-artifact@v4 is a floating
tag, so GitHub refuses with 'all actions must be pinned to a full-length commit
SHA' — the job dies before running a single step.

Move to the same revision the working publishers in this estate use:
actions/upload-pages-artifact@fc324d3 # v5.0.0.

Signed-off-by: Jonathan D.A. Jewell <[email protected]>
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 627881b into main Oct 3, 2026
26 of 30 checks passed
@hyperpolymath
hyperpolymath deleted the fix/artifact-pin branch October 3, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant