fix(pages): pin upload-pages-artifact to v5.0.0 - #74
Merged
Merged
Conversation
With sha_pinning_required, the older upload-pages-artifact (v3) is rejected at job setup: its internal reference to actions/upload-artifact@v4 is a floating tag, so GitHub refuses with 'all actions must be pinned to a full-length commit SHA' — the job dies before running a single step. Move to the same revision the working publishers in this estate use: actions/upload-pages-artifact@fc324d3 # v5.0.0. Signed-off-by: Jonathan D.A. Jewell <[email protected]>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With sha_pinning_required, the older upload-pages-artifact (v3) is rejected at job setup: its internal reference to actions/upload-artifact@v4 is a floating tag, so GitHub refuses with 'all actions must be pinned to a full-length commit SHA' — the job dies before running a single step.
Move to the same revision the working publishers in this estate use: actions/upload-pages-artifact@fc324d3 # v5.0.0.
Summary
Changes
RSR Quality Checklist
Required
just testor equivalent)just fmtor equivalent)unsafeblocks without// SAFETY:commentsbelieve_me,unsafeCoerce,Obj.magic,Admitted,sorry).envfiles includedAs Applicable
.machine_readable/STATE.a2mlupdated (if project state changed).machine_readable/ECOSYSTEM.a2mlupdated (if integrations changed).machine_readable/META.a2mlupdated (if architectural decisions changed)TOPOLOGY.mdupdated (if architecture changed)CHANGELOGor release notes updatedsrc/abi/andffi/zig/consistent)Testing
Screenshots