Repository navigation
fix(release): include ed25519_bip32_wasm.js in the published npm tarball - #223
Merged
patextreme merged 2 commits intoJun 11, 2026
Merged
Conversation
Signed-off-by: Pat Losoponkul <[email protected]>
patextreme
force-pushed
the
fix/npm-bip32-wasm-assemble-dependency
branch
from
June 10, 2026 14:05
6e9ebf8 to
aaacd0a
Compare
Reverting to the gradle publish task would run without credentials: 6c8640f removed NPM_TOKEN from the workflow env, and the petuska plugin's bundled npm is not the OIDC-capable CLI. The assembleJsPackage dependency on npmBip32Wasm already makes the staged directory complete for the npm CLI path, and the smoke test guards the tarball contents. Co-Authored-By: Claude Opus 4.8 <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]>
patextreme
force-pushed
the
fix/npm-bip32-wasm-assemble-dependency
branch
from
June 10, 2026 14:29
106aed2 to
8b59ef8
Compare
|
yshyn-iohk
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 1.8.5 npm release of
@hyperledger/identus-apolloshipped a tarball missinged25519_bip32_wasm.js. The file is required at runtime byapollo.js(line 2497 of the bundled output doesrequire('./ed25519_bip32_wasm.js')), and consumers fail at module load withCannot find module './ed25519_bip32_wasm.js'. Observed in the Identusintegrationtest suite against[email protected], which transitively pullsidentus-apollo@^1.4.5and resolves to the broken 1.8.5.Root cause — commit 6c8640f ("fix(release): use npm OIDC publishing") switched the release workflow's NPM publish step from a gradle task (
./gradlew :apollo:publishJsPackageToNpmjsRegistry) to a plainnpm publishshell command. ThenpmBip32Wasmtask (which copies the wasm artifact intoapollo/build/packages/js/) was only wired as adependsOnofNpmPublishTaskfrom thedev.petuska.npm.publishgradle plugin, so bypassing that task severed the chain. The build directory at publish time no longer containeded25519_bip32_wasm.js, but the require call inapollo.jswas still there.Changes
apollo/build.gradle.kts— addtasks.named("assembleJsPackage") { dependsOn("npmBip32Wasm") }. This makes the staged build directory complete on its own, regardless of whether the publish step is invoked via gradle or the npm CLI. Mirrors the pattern already used forjsBrowserProductionLibraryDistributionandjsNodeProductionLibraryDistribution(which both depend oncopyBip32Wasm)..github/workflows/release.yml— add an "NPM publish smoke test" step that runsnpm packon the staged directory and assertsed25519_bip32_wasm.jsis in the tarball. Harmless under the current gradle-based publish; fails loudly if a future change bypasses the gradle task again. This is regression protection, not a fix in its own right.How to verify the fix locally
After this lands, a release run should produce an npm tarball that contains
ed25519_bip32_wasm.js. You can confirm by downloading the artifact from the workflow'snpmBip32Wasmtask output, or by inspecting the published tarball:Checklist
Related
release/1.8.5hyperledger-identus/integrationtest runs 27255955264 and 27277022285 (the first hit this in the wild via[email protected]→[email protected])