Repository navigation
Honor sensitive headers on exact HPACK table matches - #996
Open
MattJackson wants to merge 2 commits into
Open
MattJackson wants to merge 2 commits into
MattJackson wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A header value marked sensitive could still use the indexed representation when it exactly matched a static or dynamic HPACK table entry. For example, sensitive
accept-encoding: gzip, deflateencoded as the static index alone, and a previously public custom value encoded as its dynamic index.Route full matches through one helper that keeps the name index but emits the sensitive value as a never-indexed literal. Public values retain their existing indexed representation, and the sensitive lookup does not modify the dynamic table or its public entry.
Validation: the two new regressions fail against the unmodified 0.4.18 release and pass with this fix.
cargo test --libpasses on this branch based on current upstream master: 448 passed, 1 ignored. The same patch on 0.4.18 passes 435 library tests (1 ignored), and actual HTTP/2 wire tests confirm both static and previously public dynamic matches carry the never-indexed representation.