Repository navigation
fix: keep screen signaling WebSocket alive - #17
Merged
Merged
Conversation
Owner
|
Hi, I'm sorry for the late reply. I was busy over the last few months. I'd like to work on this project again soon, as well as merge your great contribution. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x63key-frame request by callingagent.PLIRequest()Problem
handleScreenWSreturned immediately after sendingwebrtc_metainfo. That left no reader for the upgraded WebSocket, so control frames and the key-frame request sent bypublic/static/connect.jswere never consumed. Idle signaling connections could also be reaped while the WebRTC peer remained healthy.Verification
go test ./...successfully with Go 1.25.4