[v1.20] Move the options of the dissolved stream, ui and web modules - #241
Open
luke- wants to merge 1 commit into
Open
[v1.20] Move the options of the dissolved stream, ui and web modules#241luke- wants to merge 1 commit into
luke- wants to merge 1 commit into
Conversation
HumHub 1.20 dissolves three core modules. Their configuration options did not disappear, they moved: - the five stream options are configured on the content module now - iconAlias became the icon.alias application parameter - enableServiceWorker became the pwa.enabled application parameter - the web security settings became response.defaultHeaders on the response component The last three are no longer module options, so they leave the "Core Modules" section for two new ones. A leftover section for any of the three module ids is ignored without an error, which is what makes this worth calling out in the content section. Also corrects the documented default of defaultStreamSuppressQueryIgnore, which is Post and Activity rather than an empty array, and adds streamSuppressLimit, which was never listed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HumHub 1.20 dissolves the
stream,uiandwebcore modules (humhub/humhub#8479, #8471, #8457). Their configuration options did not disappear — they moved, andconfig-options.mdstill documents them at their old place.Merge this when 1.20 ships, not before: until then the page would describe options that do not exist yet in the released version.
What changed on the page
streamExcludes,streamSuppressQueryIgnore,defaultStreamSuppressQueryIgnore,streamSuppressLimit,showDeactivatedUserContentmodules.streammodules.contenticonAliasmodules.uiparams.icon.aliasenableServiceWorkermodules.webparams.pwa.enabledsecuritymodules.webcomponents.response.defaultHeadersThe stream options join the existing Content section. The other three are no longer module options at all, so the
### UIand### Websections go and the options move into two new top-level sections, Application Parameters and Components — the page only had## Core Modulesuntil now.A
:::notein the Content section points out that a leftoverstreamsection is ignored without an error: nothing reads the configuration of a module id that no longer exists, so there is no log entry and no warning, and the defaults quietly apply again. The same holds foruiandweb.For
defaultHeadersthe note also records that the oldcspandcsp-report-onlysections and the separatenonceswitch were removed rather than renamed — a policy expressed that way has to be rewritten as a header string.Two fixes along the way
defaultStreamSuppressQueryIgnorewas documented as[]. It has never been empty; the default isPostandActivity.streamSuppressLimitwas missing entirely. Added with its default of2.The administrator-facing side of the move is described in
docs/admin/upgrade-v1.20.mdin the core repository; this page is the reference counterpart.