Disallow use function and use const

[mikeselander]

This addition disallows developers from using functions, while keeping the ability to use namespaces and constants.

Special thanks to @jrfnl for building this ruleset for us and making this so easy to use!

[jrfnl]

Special thanks to @jrfnl for building this ruleset for us and making this so easy to use!

Well, didn't build it just for you, but glad you like it. ;-)

[rmccue]

Are these changes intentional? Neither of them will have any effect if the project isn't the root project.

[mikeselander]

They were, yes. phpcsextra is only released as alpha and it wouldn't install without adding these in: https://github.com/PHPCSStandards/PHPCSExtra/releases

[rmccue]

OK, we'll have to hold on releasing this then until phpcsextra is released, as the minimum-stability won't flow through, and would make the coding standards uninstallable as a dependency.

[roborourke]

Requested a stable release: PHPCSStandards/PHPCSExtra#91

[kadamwhite]

@roborourke and cc @rmccue for the legacy piece -- we still want this? Could probably get it in now with a refreshed patch

[roborourke]

Unless there are newer releases then yes I think so. Is it still needed even with the latest WPCS versions?

I can't remember the logic behind disallowing them but I don't care that much personally.

[goldenapples]

👍 to refreshing this so it can be merged. Our coding standards are pretty explicit about this:

• Importing functions explicitly with use function should be avoided.
• Aliasing functions explicitly with use function ... as should also be avoided.
• Parent namespaces are preferred for importing functions.

and it would be nice to have this enforced by phpcs rather than discussing case by case.

[rmccue]

Yep, still an intentional part of the standards so +1 to getting it in