Add a Discord link to the site footer - #88
Merged
Merged
Conversation
Bumps the npm-development group with 1 update in the / directory: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node). Updates `@types/node` from 26.6.1 to 26.6.2 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.6.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-development ... Signed-off-by: dependabot[bot] <[email protected]>
…/dev/npm-development-56e245307c chore(deps-dev): bump @types/node from 26.6.1 to 26.6.2 in the npm-development group across 1 directory
Remove the Support item from the Community column and add a Discord link below GitHub, using the community invite used elsewhere on the site.
docs: replace footer Support link with Discord invite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes
devtomainfor the documentation site.Supportlink with aDiscordlink in the Community column.@types/node.mainis an ancestor ofdev, so this promotion applies cleanly with no conflicts.What readers see
Every page ends with the same footer. The Community column now sends readers to the community chat instead of the Support page:
The
Discorditem sits directly belowGitHub, opens the community invite (https://discord.gg/sjrw8QXNks) in a new tab, and follows the same external-link treatment as the other footer links (opens in a new tab,rel="noreferrer noopener", screen-reader note).The Support page is unchanged and still available at
/docs/support; only the footer link was removed.Visuals
Changes
.vitepress/theme/components/SiteFooter/SiteFooter.vueDISCORD_URL, adds theDiscordlink belowGitHub, removes theSupportlink.package.json@types/nodefrom^26.6.1to^26.6.2.package-lock.json@types/nodeto26.6.2.Maintenance updates
@types/nodeThe
@types/nodeupdate changes type definitions for local development and the build only. It has no effect on the published site.Verification
The two constituent pull requests passed the pull request checks before merge:
@types/nodebumpThe footer was also rendered locally on the home page, and the link order was confirmed in a real browser.
Deployment
flowchart LR D["dev"] --> P["Promote to main"] P --> B["Deploy workflow: npm ci and npm run build"] B --> Pages["GitHub Pages"]The Pages workflow deploys on push to
main. Merging this pull request publishes the footer change to the live site.