linux: fix calculating size incorrectly and handle read errors while reading environment

[dasha-uwu]

1. Extra size += bytes statement at line 548 advanced size past valid data, because the last do-while loop body already did size += bytes for the same bytes value

2. The if (bytes < 0) block was unreachable because fread can't return < 0, replaced with detecting errors with ferror

3. Rewrite the read loop for clarity

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 1898fd34-3087-41f2-bb5f-37b610e1fbdb

📥 Commits

Reviewing files that changed from the base of the PR and between 44a59cf and 0220cbf.

📒 Files selected for processing (1)

• linux/Platform.c

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Platform_getProcessEnv now reads the process environment in chunks until fread returns fewer bytes than requested. It checks ferror after the loop. On a read error, it closes the file, frees the buffer, and returns NULL.

Suggested reviewers: germanaizek

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 0220c

The environment reader preserves its data at chunk boundaries and handles read errors; no actionable merge risk was identified in the reviewed change.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Chunks pass through the reading stream
Each byte count updates the buffer
A short read brings the loop to rest
Read errors close the file
The buffer is freed, and NULL returns}

_{Comment @coderabbitai help to get the list of available commands.}

[BenBE]

Superseeded by cb613e6.