Skip to content

Let playlist songs be rated, play only the ones rated in, and keep a scrolled list where it is - #6

Merged
hsshss merged 2 commits into
mainfrom
playlist-rating
Oct 22, 2026
Merged

hsshss merged 2 commits into
mainfrom
playlist-rating

Conversation

@hsshss

@hsshss hsshss commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Lets each song in a playlist be marked as a favorite or disliked, lets the player go through only the songs rated in, and stops a double-click from pulling a scrolled list back to where it was last playing.

Rating

  • A star column before the title cycles a song through none (☆), favorite (★) and disliked (a star with a slash) on each click. A press on the star never starts a row drag, and a double-click on it does not play the song.
  • The rating is the file's: the same path in every open list takes it too, compared without case as the lists' own files are. Lists that are not open are not touched.
  • It is kept in the playlist file as rating, left out when none, so older lists read as they were and PlaylistFile.FormatVersion stays at 1. A rating: left without a value reads as none (any enum key does now).
  • Copying, moving and duplicating a list carry it, and the Sort menu gains By Favorite: favorites first, disliked last, ties kept in order.

Songs to Play

Settings gains Songs to Play: all songs, favorites and unrated only, or favorites only. It is a setting of the player, like the play order and repeat.

  • A song the filter leaves out is to the walk what a song taken out of the list is: if it is playing it plays on, and the walk goes on to the next song let through.
  • Picked by hand it still plays, and the walk goes on from where it sits in the list, or in a random pass with the songs not yet heard.
  • A random pass is not dealt again when the filter or a rating changes; only the songs to come change.
  • A star clicked on the list being played tells the walk (Rearranged), so a song rated out is not played next.

Scroll on double-click

Playing from a list the player did not hold handed the list over first, which said the cursor was on the list's playing mark, and then asked for the song. The UI often read the cursor before the transport had moved it, so a list scrolled away from its playing mark jumped back there, and the song asked for ended up at the edge of the view. With a filter, a song it leaves out put the cursor on the next song let through instead, with the same jump.

A double-click or a drop that plays now hands the list over together with the song (PlaybackController.Play(Playlist, int)), and the cursor is said to be on that song once it is there and nowhere before.

Testing

  • dotnet test, 977 tests. New ones cover the rating's file round trip, sorting, the walk under each filter (in order and random, picked by hand, rated out while playing, the filter turned on while playing), the rating reaching the same file in other lists, and the cursor said to be only on the song played from a list handed over. Each was checked to fail with the code it guards taken out.
  • The star column, its clicks, the Sort menu, the Songs to Play menu and the saved settings were checked in the running app with a scratch settings folder. Playing under a filter and the scroll were checked by the tests only.
  • SequencerTests.KeepsEventsRoughlyOnSchedule failed twice in about twenty runs, right after a build; it times the sequencer, which this branch does not touch.

A star column before the title cycles a song through none, favorite and
disliked on each click. The rating is the file's: the same file in every
open list takes it too. It is kept in the playlist file as `rating`, left
out when none, so older lists read as they were and the format version
stays. Copying, moving and duplicating carry it, and the Sort menu gains
By Favorite: favorites first, disliked last, ties kept in order.

Settings gains Songs to Play: all songs, favorites and unrated only, or
favorites only. A song the filter leaves out is to the walk what a song
taken out of the list is: if it is playing it plays on, and the walk goes
on to the next song let through. Picked by hand it still plays, and the
walk goes on from where it sits in the list, or in a random pass with the
songs not yet heard. A star clicked on the list being played tells the
walk, so a song rated out is not played next.

A press on the star never starts a row drag, and a double-click on it does
not play the song. An enum key left without a value reads as its default.
Playing from a list the player did not hold handed the list over first,
which said the cursor was on the list's playing mark, and then asked for
the song. The list scrolls to wherever the cursor is said to be, and the
UI often read the cursor before the transport had moved it, so a list
scrolled away from its playing mark jumped back there, and the song asked
for ended up at the edge of the view. With a filter, a song it leaves out
put the cursor on the next song let through instead, with the same jump.

A double-click or a drop that plays now hands the list over together with
the song, and the cursor is said to be on that song once it is there and
nowhere before.
@hsshss
hsshss merged commit feb27e6 into main Oct 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant